Extend allowed_cloud_network for providers that don't support allowed_ci #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @gmcculloug |
d-m-u
changed the title
|
@miq-bot add_label bug |
Ladas
approved these changes
Jan 16, 2018
There was a problem hiding this comment.
Important thing is, that this fixes the CI. So I am fine merging this and backporting this, so we get also g-release CI in order.
We could then abstract the common code to base class, probably as upstream only PR?
@aufi this is basically a revert of Ladas/manageiq@2784dce#diff-affc070fa31fb03b3d1afa85434e8f3d
d-m-u
changed the title
d-m-u
force-pushed
the
fixing_allowed_cloud_networks
branch
from
cf8d00e
to
f2cb328
Compare
|
Checked commit d-m-u@f2cb328 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@aufi can this please get reviewed again/merged ASAP? |
d-m-u
added a commit
to d-m-u/manageiq-providers-openstack
that referenced
this pull request
Jan 18, 2018
|
Removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR ManageIQ/manageiq#16811 and ManageIQ/manageiq#16688 adds RBAC filtering to allowed_cloud_network base class but two of the providers don't support the allowed_ci method so for them we need to overwrite the allowed_cloud_networks, to just return allowed_cloud_networks. Which this does! (Per ManageIQ/manageiq#16824 (comment))
Fixes issue caused by fix of https://bugzilla.redhat.com/show_bug.cgi?id=1533277
(Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1535189)
Related to:
ManageIQ/manageiq-providers-google#41