Bypass the superclass orchestrated destroy for this Provider. #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the OpenStack provider, the Provider instance is only tightly coupled to the InfraManager. That is, when the InfraManager is created, then the Provider is created and vice-versa, when the InfraManager is destroyed, we need to destroy the Provider. The CloudManager objects associated to that Provider should *not* be destroyed, and only need to be nullified. For other Providers, the Provider instance is what is destroyed, so by default the orchestrated destroy destroys all of its managers, but we here don't want that to happen, so we are bypassing. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1538232
|
Checked commit Fryguy@0938e66 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Ladas
approved these changes
Jan 25, 2018
simaishi
pushed a commit
that referenced
this pull request
Jan 25, 2018
Bypass the superclass orchestrated destroy for this Provider. (cherry picked from commit 158b93f) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1538240
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the OpenStack provider, the Provider instance is only tightly coupled
to the InfraManager. That is, when the InfraManager is created, then
the Provider is created and vice-versa, when the InfraManager is
destroyed, we need to destroy the Provider. The CloudManager objects
associated to that Provider should not be destroyed, and only need to
be nullified. For other Providers, the Provider instance is what is
destroyed, so by default the orchestrated destroy destroys all of its
managers, but we here don't want that to happen, so we are bypassing.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1538232
@Ladas @aufi Please review
cc @agrare @jameswnl