Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Event payload to empty Hash #262

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Default Event payload to empty Hash #262

merged 1 commit into from
Mar 29, 2018

Conversation

aufi
Copy link
Member

@aufi aufi commented Mar 29, 2018

Event payload received from OpenStack could have nil content which
resulted in failures in code assigning Event to inventory.

Defaulting empty hash for payload to avoid it.

Should fix https://bugzilla.redhat.com/show_bug.cgi?id=1519887

@aufi
Default Event payload to empty Hash
8c7b44d 
Event payload received from OpenStack could have nil payload which
resulted in failures in code assigning Event to inventory. Default
empty hash for payload to avoid it.

Should fix https://bugzilla.redhat.com/show_bug.cgi?id=1519887
@miq-bot
Copy link
Member

miq-bot commented Mar 29, 2018

Checked commit aufi@8c7b44d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🏆

@aufi
Copy link
Member Author

aufi commented Mar 29, 2018 •
edited
Loading

Codeclimate complains about block of code which was just very slightly updated (... || {}). I don't think refactoring the duplicate code is in scope of this PR.

@mansam
Copy link
Contributor

mansam commented Mar 29, 2018

👍

@mansam mansam merged commit e62a44f into ManageIQ:master Mar 29, 2018
simaishi pushed a commit that referenced this pull request Apr 9, 2018
@mansam @simaishi
Merge pull request #262 from aufi/default_empty_event_payload
78966d4 
Default Event payload to empty Hash
(cherry picked from commit e62a44f)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1565167
@simaishi
Copy link
Contributor

simaishi commented Apr 9, 2018

Gaprindashvili backport details:

$ git log -1
commit 78966d4a8ab89749b579af2ab8a933ead363e3f6
Author: Samuel Lucidi <mansam@csh.rit.edu>
Date:   Thu Mar 29 10:00:11 2018 -0400

    Merge pull request #262 from aufi/default_empty_event_payload
    
    Default Event payload to empty Hash
    (cherry picked from commit e62a44f3655c1285bcabd611c7f23559bd52c64b)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1565167

@simaishi
Copy link
Contributor

simaishi commented Apr 9, 2018

Fine backport (to manageiq repo) details:

$ git log -1
commit 627390f7423321d216f58ab288020c71b7890fa5
Author: Samuel Lucidi <mansam@csh.rit.edu>
Date:   Thu Mar 29 10:00:11 2018 -0400

    Merge pull request #262 from aufi/default_empty_event_payload
    
    Default Event payload to empty Hash
    (cherry picked from commit e62a44f3655c1285bcabd611c7f23559bd52c64b)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1565169

@aufi aufi added this to the Sprint 83 Ending Apr 9, 2018 milestone Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocker bug fine/backported gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aufi @miq-bot @mansam @simaishi