-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GAPRINDASHVILI] Implement Graph Refresh for the Cinder Manager #274
[GAPRINDASHVILI] Implement Graph Refresh for the Cinder Manager #274
Conversation
6dc7408
to
4e203e8
Compare
Some comments on commits mansam/manageiq-providers-openstack@a5a9017~...4e203e8 spec/models/manageiq/providers/openstack/storage_manager/cinder_manager/event_target_parser_spec.rb
|
Checked commits mansam/manageiq-providers-openstack@a5a9017~...4e203e8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
app/models/manageiq/providers/openstack/cinder_manager_mixin.rb
app/models/manageiq/providers/openstack/inventory_collection_default/storage_manager.rb
|
@aufi could you review this so it can get merged? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for late reaction, LGTM 👍
Backport of #194
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1566541
Tried to set this up so it can be merged after #273 without a VCR conflict.