Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAPRINDASHVILI] Implement Graph Refresh for the Cinder Manager #274

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Apr 13, 2018

Backport of #194
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1566541

Tried to set this up so it can be merged after #273 without a VCR conflict.

@mansam mansam changed the title [WIP][Gaprindashvili] Implement Graph Refresh for the Cinder Manager (Depends on #273)[Gaprindashvili] Implement Graph Refresh for the Cinder Manager Apr 13, 2018
@miq-bot miq-bot changed the title (Depends on #273)[Gaprindashvili] Implement Graph Refresh for the Cinder Manager [GAPRINDASHVILI] (Depends on #273)[Gaprindashvili] Implement Graph Refresh for the Cinder Manager Apr 13, 2018
@simaishi simaishi changed the title [GAPRINDASHVILI] (Depends on #273)[Gaprindashvili] Implement Graph Refresh for the Cinder Manager [GAPRINDASHVILI] Implement Graph Refresh for the Cinder Manager Apr 13, 2018
@simaishi simaishi requested a review from aufi April 13, 2018 17:19
@simaishi simaishi self-assigned this Apr 13, 2018
@simaishi simaishi added the bug label Apr 13, 2018
@mansam mansam force-pushed the gaprindashvili-implement-graph-refresh-for-cinder branch from 6dc7408 to 4e203e8 Compare April 13, 2018 17:20
@miq-bot
Copy link
Member

miq-bot commented Apr 13, 2018

Some comments on commits mansam/manageiq-providers-openstack@a5a9017~...4e203e8

spec/models/manageiq/providers/openstack/storage_manager/cinder_manager/event_target_parser_spec.rb

  • ⚠️ - 6 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@miq-bot
Copy link
Member

miq-bot commented Apr 13, 2018

Checked commits mansam/manageiq-providers-openstack@a5a9017~...4e203e8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
32 files checked, 5 offenses detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

app/models/manageiq/providers/openstack/cinder_manager_mixin.rb

app/models/manageiq/providers/openstack/inventory_collection_default/storage_manager.rb

@mansam
Copy link
Contributor Author

mansam commented Apr 16, 2018

@aufi could you review this so it can get merged? :)

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late reaction, LGTM 👍

@simaishi simaishi merged commit 24bb208 into ManageIQ:gaprindashvili Apr 17, 2018
@simaishi simaishi added this to the Sprint 84 Ending Apr 23, 2018 milestone Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants