bug 1513086: add cores per socket to OpenStack cloud inventory parser #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1513086 For OpenStack cloud, cpu_cores_per_socket was always set to 1 in the legacy refresh_parser since OpenStack flavors only have a single "number of CPUs" param. The new inventory parser was not setting this param at all, though, leaving it as nil.
|
Note that if this PR needs to be backported to gaprindashvili it's not a clean backport. To work on gaprindashvili we also need to modify app/models/manageiq/providers/openstack/inventory_collection_default/cloud_manager.rb which has been deleted on master, so that change wasn't needed for this to work on master. |
|
Checked commit sseago@4d0c9df with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Looks good to me, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1513086
For OpenStack cloud, cpu_cores_per_socket was always set to 1 in the legacy refresh_parser
since OpenStack flavors only have a single "number of CPUs" param. The new inventory
parser was not setting this param at all, though, leaving it as nil.