Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format error when physical network is in use #370

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Format error when physical network is in use #370

merged 1 commit into from
Oct 8, 2018

Conversation

alexander-demicev
Copy link

Format error when creating cloud "flat" network if physical network is in use

screen shot 2018-10-08 at 11 36 02

https://bugzilla.redhat.com/show_bug.cgi?id=1635617

@aufi @mansam

@mansam
Copy link
Contributor

mansam commented Oct 8, 2018

The "Unable to create" part of the message is duplicated in the screenshot, probably because both the UI controller and the method here include it. Maybe remove that sentence from the reformatted error message in order to get rid of that duplication?

@alexander-demicev
Copy link
Author

Thanks, I missed it somehow

@mansam
Copy link
Contributor

mansam commented Oct 8, 2018

Thanks! LGTM

@mansam mansam merged commit 4586a35 into ManageIQ:master Oct 8, 2018
@aufi aufi added the bug label Oct 9, 2018
@aufi aufi added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 9, 2018
@simaishi
Copy link
Contributor

simaishi commented Oct 9, 2018

@alexander-demichev Can this be hammer/yes?

@simaishi
Copy link
Contributor

@alexander-demichev ^ping

@alexander-demicev
Copy link
Author

@simaishi Sorry for late response, missed your comment.

@alexander-demicev
Copy link
Author

@miq-bot add_label hammer/yes

simaishi pushed a commit that referenced this pull request Oct 15, 2018
@mansam @simaishi
Merge pull request #370 from alexander-demichev/physical-network-error
a54e587 
Format error when physical network is in use

(cherry picked from commit 4586a35)

https://bugzilla.redhat.com/show_bug.cgi?id=1635617
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit a54e587bbf1b7754406763deab010be96e8a5048
Author: Samuel Lucidi <mansam@csh.rit.edu>
Date:   Mon Oct 8 17:12:09 2018 -0400

    Merge pull request #370 from alexander-demichev/physical-network-error
    
    Format error when physical network is in use
    
    (cherry picked from commit 4586a355b8bbc83d0d99554035a0004c4dc10ab3)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1635617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexander-demicev @mansam @simaishi @aufi @miq-bot