Bug 1664888: Warn, but still allow infra without ironic #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UI validation warning display requires ManageIQ/manageiq-ui-classic#5200 to show it, but there should be no build/run dependencies between the PRs |
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1664888 This commit changes the validation to warn but not fail for infra providers without Ironic. In addition, refresh no longer fails if ironic is missing -- it just logs a warning instead.
sseago
force-pushed
the
undercloud-without-ironic
branch
from
12a10c7
to
82ad959
Compare
|
Checked commit sseago@82ad959 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Looks good to me, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1664888
This commit changes the validation to warn but not fail for
infra providers without Ironic. In addition, refresh no longer
fails if ironic is missing -- it just logs a warning instead.