Add flavors info in instance provisioning #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
force-pushed
the
flavors-in-inst-provisioning
branch
from
e89e6c6
to
200878b
Compare
|
Hi! It looks like the tests need to be updated. I'm also not seeing the updated descriptions, am I missing a patch? |
alexander-demicev
force-pushed
the
flavors-in-inst-provisioning
branch
2 times, most recently
from
f5ec37d
to
2c99cfc
Compare
|
Works for me; resolve rubocop, thanks! |
alexander-demicev
force-pushed
the
flavors-in-inst-provisioning
branch
from
2c99cfc
to
87daade
Compare
|
In that case, I think this can be merged once the tests are done being updated! |
alexander-demicev
force-pushed
the
flavors-in-inst-provisioning
branch
from
87daade
to
bd5b69a
Compare
|
Checked commit alexander-demicev@bd5b69a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@tzumainn It`s ok now :) |
|
Okay, I fixed my environment, and this works for me as well. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flavors info when selecting flavor in instance provisioning.
https://bugzilla.redhat.com/show_bug.cgi?id=1396529