Add support for bevy_xpbd
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution, should I merge #21 first ? And then you'll rebase? |
ManevilleF
reviewed
Nov 10, 2023
| use bevy_xpbd_3d::prelude::*; | ||
|
|
||
| fn get_collider(aabb: &Aabb, collider: &ClothCollider) -> Collider { | ||
| let extents = aabb.half_extents * 2.0 + collider.offset; |
There was a problem hiding this comment.
Why is the * 2.0 needed? We don't do that in rapier
There was a problem hiding this comment.
Collider::cuboid currently takes full extents to match Bevy's shape APIs better
|
Yeah, you can merge that one first. I'll fix the format warning here and add these changes to the changelog as well, and then rebase |
ManevilleF
approved these changes
Nov 12, 2023
|
Btw to synchronize the README and lib.rs I use cargo-sync-readme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #21; merge that first.
This PR adds support for
bevy_xpbdas an alternative physics backend.Changes
xpbd_collisionsfeaturerapierandxpbdsub-modules forcollisionsxpbd_collisionexample; a clone ofrapier_example, but modified forbevy_xpbdREADME.mdandsrc/lib.rsto have separate sections forbevy_rapierandbevy_xpbd. If you'd like it to be changed more, let me know :)