feat: do not refresh status if not on status page or looking at the s…

…tatus popup
Mangatsu · Jan 20, 2024 · c36c971 · c36c971
1 parent 1683282
commit c36c971
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 6 deletions.
diff --git a/app/status/status.tsx b/app/status/status.tsx
@@ -13,7 +13,7 @@ export function statusMessage(running: boolean) {
 }
 
 function StatusPage() {
-  const { data } = useProcessingStatus()
+  const { data } = useProcessingStatus(true)
 
   const errorPopup = (key: number, triggerText: string, error: string, details: Map<string, string>) => {
     return (

diff --git a/components/Nav/NavPopup.tsx b/components/Nav/NavPopup.tsx
@@ -7,9 +7,11 @@ interface Props {
   children: ReactNode
   menuRef?: RefObject<PopupActions>
   isLink?: boolean
+  isVisible?: boolean
+  onVisibilityChange?: (isOpen: boolean) => void
 }
 
-const NavPopup = ({ triggerChildren, children, menuRef, isLink }: Props) => {
+const NavPopup = ({ triggerChildren, children, menuRef, isLink, isVisible, onVisibilityChange }: Props) => {
   return (
     <Popup
       trigger={
@@ -28,6 +30,9 @@ const NavPopup = ({ triggerChildren, children, menuRef, isLink }: Props) => {
       position="bottom right"
       arrow={false}
       ref={menuRef}
+      open={isVisible}
+      onOpen={onVisibilityChange ? () => onVisibilityChange(true) : () => {}}
+      onClose={onVisibilityChange ? () => onVisibilityChange(false) : () => {}}
     >
       <div
         className="rounded bg-slate-700 w-auto h-auto min-w-64 flex flex-col py-2"

diff --git a/components/Nav/RunTasks.tsx b/components/Nav/RunTasks.tsx
@@ -1,5 +1,6 @@
 "use client"
 import Image from "next/image"
+import { useState } from "react"
 import { toast } from "react-toastify"
 import { statusMessage } from "../../app/status/status"
 import { initiateMetadataGen, initiateScan, initiateThumbnailGen } from "../../lib/api/task"
@@ -9,7 +10,9 @@ import Button from "../Button"
 import NavPopup from "./NavPopup"
 
 const RunTasks = () => {
-  const { data } = useProcessingStatus()
+  const [isVisible, setIsVisible] = useState(false)
+
+  const { data } = useProcessingStatus(isVisible)
 
   // TODO: More options to the UI such as quick scan, covers only thumnbnail generation etc.
   // const quickScanHandler = async () => {
@@ -32,6 +35,10 @@ const RunTasks = () => {
     await initiateThumbnailGen(true, true)
   }
 
+  const onVisibilityChange = (isOpen: boolean) => {
+    setIsVisible(isOpen)
+  }
+
   if (!data) {
     return (
       <NavPopup triggerChildren={<Image width={24} height={24} alt="scan menu" src={ScanIcon} />}>
@@ -52,7 +59,11 @@ const RunTasks = () => {
   }
 
   return (
-    <NavPopup triggerChildren={<Image width={24} height={24} alt="scan menu" src={ScanIcon} />}>
+    <NavPopup
+      triggerChildren={<Image width={24} height={24} alt="scan menu" src={ScanIcon} />}
+      isVisible={isVisible}
+      onVisibilityChange={onVisibilityChange}
+    >
       <Button href="/status#thumbnails" className="mx-4 my-2 w-60">
         View stats
       </Button>

diff --git a/lib/hooks/data/useProcessingStatus.ts b/lib/hooks/data/useProcessingStatus.ts
@@ -4,8 +4,8 @@ import { APIPathsV1, swrFetcher } from "../../api/other"
 
 const fetcher: Fetcher<ProcessingStatus, string> = (id) => swrFetcher(id)
 
-export default function useProcessingStatus() {
-  const { data } = useSWR(APIPathsV1.Status, (key) => fetcher(key), { refreshInterval: 1000 })
+export default function useProcessingStatus(refresh?: boolean) {
+  const { data } = useSWR(APIPathsV1.Status, (key) => fetcher(key), { refreshInterval: refresh ? 2000 : 0 })
 
   return {
     data,