Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies: Use serde_json instead of rustc-serialize, update winapi, log #104

Merged
merged 4 commits into from
Mar 13, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,18 @@ name = "compiletest_rs"
diff = "0.1.10"
filetime = "0.1"
getopts = "0.2"
log = "0.3"
rustc-serialize = "0.3"
log = "0.4"
tempdir = { version = "0.3", optional = true }
serde = "1.0"
serde_json = "1.0"
serde_derive = "1.0"

[target."cfg(unix)".dependencies]
libc = "0.2"

[target."cfg(windows)".dependencies]
miow = "0.2"
winapi = "0.2"
miow = "0.3"
winapi = { version = "0.3", features = ["winerror"] }

[features]
tmp = ["tempdir"]
12 changes: 6 additions & 6 deletions src/json.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@
// except according to those terms.

use errors::{Error, ErrorKind};
use rustc_serialize::json;
use serde_json;
use std::str::FromStr;
use std::path::Path;
use runtest::ProcRes;

// These structs are a subset of the ones found in
// `syntax::json`.

#[derive(RustcEncodable, RustcDecodable)]
#[derive(Deserialize)]
struct Diagnostic {
message: String,
code: Option<DiagnosticCode>,
Expand All @@ -27,7 +27,7 @@ struct Diagnostic {
rendered: Option<String>,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rendered field is unused, should I remove it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never answered your question here. I'm about to release 0.3.8 and wondering if this warning should be removed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it occurs in rustc/compiletest as well?

Copy link
Contributor Author

@messense messense Mar 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, ok thanks for checking that, I'll remove it and release 0.3.9 with that if the need arises

}

#[derive(RustcEncodable, RustcDecodable, Clone)]
#[derive(Deserialize, Clone)]
struct DiagnosticSpan {
file_name: String,
line_start: usize,
Expand All @@ -40,7 +40,7 @@ struct DiagnosticSpan {
expansion: Option<Box<DiagnosticSpanMacroExpansion>>,
}

#[derive(RustcEncodable, RustcDecodable, Clone)]
#[derive(Deserialize, Clone)]
struct DiagnosticSpanMacroExpansion {
/// span where macro was applied to generate this code
span: DiagnosticSpan,
Expand All @@ -49,7 +49,7 @@ struct DiagnosticSpanMacroExpansion {
macro_decl_name: String,
}

#[derive(RustcEncodable, RustcDecodable, Clone)]
#[derive(Deserialize, Clone)]
struct DiagnosticCode {
/// The code itself.
code: String,
Expand All @@ -67,7 +67,7 @@ fn parse_line(file_name: &str, line: &str, output: &str, proc_res: &ProcRes) ->
// The compiler sometimes intermingles non-JSON stuff into the
// output. This hack just skips over such lines. Yuck.
if line.starts_with('{') {
match json::decode::<Diagnostic>(line) {
match serde_json::from_str::<Diagnostic>(line) {
Ok(diagnostic) => {
let mut expected_errors = vec![];
push_expected_errors(&mut expected_errors, &diagnostic, &[], file_name);
Expand Down
4 changes: 3 additions & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,16 @@
extern crate libc;
extern crate test;
extern crate rustc;
extern crate rustc_serialize;

#[cfg(feature = "tmp")] extern crate tempdir;

#[macro_use]
extern crate log;
extern crate filetime;
extern crate diff;
extern crate serde_json;
#[macro_use]
extern crate serde_derive;

use std::env;
use std::ffi::OsString;
Expand Down
2 changes: 1 addition & 1 deletion src/read2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ mod imp {
use self::miow::iocp::{CompletionPort, CompletionStatus};
use self::miow::pipe::NamedPipe;
use self::miow::Overlapped;
use self::winapi::ERROR_BROKEN_PIPE;
use self::winapi::shared::winerror::ERROR_BROKEN_PIPE;

struct Pipe<'a> {
dst: &'a mut Vec<u8>,
Expand Down