Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note to the README concerning paths with spaces and link_deps() #82

Merged
merged 1 commit into from
Oct 13, 2017

Conversation

laumann
Copy link
Collaborator

@laumann laumann commented Oct 12, 2017

If any of the paths added to target_rustcflags by link_deps() contain
spaces, then compiletest breaks as split_maybe_args does not handle
paths with spaces correctly.

If any of the paths added to target_rustcflags by link_deps() contain
spaces, then compiletest breaks as `split_maybe_args` does not handle
paths with spaces correctly.
@hdhoang
Copy link
Contributor

hdhoang commented Oct 13, 2017

This caveat also applies to clean_rmeta, so I'll rebase #79 later on.

@laumann
Copy link
Collaborator Author

laumann commented Oct 13, 2017

OK, I'll try to see if I can fix it soon.

@laumann laumann merged commit ec8db8d into master Oct 13, 2017
@laumann laumann deleted the link-deps-caveat branch October 13, 2017 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants