Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GcCellRef::filter_map, GcCellRefMut::filter_map #177

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Add GcCellRef::filter_map, GcCellRefMut::filter_map #177

merged 4 commits into from
Jul 17, 2024

Conversation

andersk
Copy link
Collaborator

@andersk andersk commented Jul 17, 2024

@andersk
Fix GcCellRef::map doctest
8a5cfdd 
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Manishearth
Manishearth approved these changes Jul 17, 2024
View reviewed changes
Copy link
Owner

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i'm convinced this is sound

thanks for the speedy patch! small nit to fix and then we can merge this

gc/src/lib.rs Outdated Show resolved Hide resolved
@Manishearth Manishearth mentioned this pull request Jul 17, 2024
Closed
andersk added 2 commits July 17, 2024 11:58
@andersk
Simplify with ManuallyDrop
d25e341 
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk
Add GcCellRef::filter_map
d50f6c0 
Fixes Manishearth#176.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk
Add GcCellRefMut::filter_map
2bbea85 
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@Manishearth Manishearth merged commit d445318 into Manishearth:master Jul 17, 2024
1 check passed
@andersk andersk deleted the filter_map branch October 2, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pls add GcCellRef::filter_map like in std::cell::Ref::filter_map
2 participants
@andersk @Manishearth