Merge upstream #3
Merged
+2,744
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some modifications turned out to be problematic and caused an exception to be thrown at startup.
I don't understand why this modification is needed, but it seems essential.
Previously GUIQuads had static colliders, which are not supposed to be moved around. Apparently this confused the physics engine and caused issues like trigger enters and trigger exits didn't match up.
The old implementation generates a rotation that's not around the y axis when it should generate a 180-degree rotation.
This means Unity won't move these cameras around. This is a farily big change, but I think it makes so much more sense this way.
This fixes noisy appearance of the tool icon. It might also fix an issue some players experience, namely that the concealer is drawn on top of the tool icon.
This allows tools to perform a long action without being interrupted by handlers.
This happened when the warp destination was so high that the parabola couldn't reach it.
... rather than around the head.
It seems to hard to justify the overhead given how infrequent its use is.
... between two or more cameras.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.