Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imputation considers only NaN; should it also consider zeros? #231

Open
acesnik opened this issue Aug 18, 2023 · 1 comment
Open

Imputation considers only NaN; should it also consider zeros? #231

acesnik opened this issue Aug 18, 2023 · 1 comment
Labels
next release This is something we have already addressed on a branch or will address before the next release.

Comments

@acesnik
Copy link

acesnik commented Aug 18, 2023

Is your feature request related to a problem? Please describe.
I was getting some mysterious negative log2-transformed values after imputation, and it took me a while to figure out that zeros aren't being imputed. I changed them to NaN, and now they're being imputed.

Describe the solution you'd like
Adding a parameter for the preprocessing engine for which values to impute. Or change the default behavior to imputing both zeros and NaN are imputed.

Describe alternatives you've considered
I found a workaround with converting zeros to NaN before running imputation.

@JuliaS92
Copy link
Collaborator

We added 0 replacement with nans to the preprocessing options and only nans are imputed. This will be in the next release.

@JuliaS92 JuliaS92 added the next release This is something we have already addressed on a branch or will address before the next release. label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release This is something we have already addressed on a branch or will address before the next release.
Projects
None yet
Development

No branches or pull requests

2 participants