Refactor analysis vii #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boopthesnoot
reviewed
Nov 8, 2024
| @@ -41,7 +41,7 @@ | |||
| # TODO show more info about the preprocessing steps | |||
| display_preprocessing_info(dataset.preprocessing_info) | |||
|
|
|||
| if c12.button("Reset all Preprocessing steps", key="_reset_preprocessing"): | |||
| if c12.button("❌ Reset all Preprocessing steps", key="_reset_preprocessing"): | |||
boopthesnoot
reviewed
Nov 8, 2024
| elif "plotly" in str(type(artifact)): | ||
| elif "plotly" in str( | ||
| type(artifact) | ||
| ): # TODO can there be non-plotly types here |
There was a problem hiding this comment.
for now i don't think so
JuliaS92
reviewed
Nov 15, 2024
| @@ -88,9 +88,9 @@ def llm_config(): | |||
| st.info("Create a Volcano plot first using the 'Analysis' page.") | |||
| st.stop() | |||
|
|
|||
| volcano_plot, parameter_dict = st.session_state[StateKeys.LLM_INPUT] | |||
| volcano_plot, plot_parameters = st.session_state[StateKeys.LLM_INPUT] | |||
There was a problem hiding this comment.
wouldn't this be analysis parameters, if we ever generalize to all analyses being interpretable by LLM?
There was a problem hiding this comment.
yes but for now it's tied to the volcano, that's we I chose to name it like so
JuliaS92
reviewed
Nov 15, 2024
JuliaS92
reviewed
Nov 15, 2024
| def display_figure(plot: PlotlyObject) -> None: | ||
| """Display plotly or seaborn figure.""" | ||
| try: | ||
| st.plotly_chart(plot.update_layout(plot_bgcolor="white")) |
There was a problem hiding this comment.
I would not set the bgcolor. Having transparent backgrounds by default is a good thing from my point of view. If this is just to select the correct st function, no update_layout is needed.
JuliaS92
reviewed
Nov 15, 2024
| except AttributeError: | ||
| plot.savefig(buffer, format=format) | ||
| plot.write_image(file=buffer, format=file_format) | ||
| except AttributeError: # TODO figure out what else "plot" can be |
JuliaS92
reviewed
Nov 15, 2024
JuliaS92
reviewed
Nov 15, 2024
JuliaS92
reviewed
Nov 15, 2024
JuliaS92
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature drop:
allow to save also statistical analysis, allow to download the resulting data.
Some frontend eye candy, and a refactoring of the frontend methods to be more DRY