Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idhandling ii #379

Merged
merged 39 commits into from
Nov 25, 2024
Merged

Idhandling ii #379

merged 39 commits into from
Nov 25, 2024

Conversation

JuliaS92
Copy link
Collaborator

Changes:

  • Volcano now labels all significant proteins using the representation dictionary
  • Intensity dropdown now shows gene names and protein ids from the keys of the mapping dictionaries
  • uniprot lookup function can now handle protein ids
  • altered what's extracted from uniprot entries

Fixes:

New

  • Functions to get uniprot output for feature ids (currenlty no automatic tests, will add them to this PR next)

@JuliaS92 JuliaS92 mentioned this pull request Nov 20, 2024
Merged
mschwoer
mschwoer reviewed Nov 21, 2024
View reviewed changes
alphastats/dataset/dataset.py Outdated Show resolved Hide resolved
alphastats/gui/utils/analysis.py Outdated Show resolved Hide resolved
alphastats/gui/utils/analysis.py Outdated Show resolved Hide resolved
alphastats/llm/uniprot_utils.py Outdated Show resolved Hide resolved
alphastats/llm/uniprot_utils.py Show resolved Hide resolved
alphastats/llm/uniprot_utils.py Show resolved Hide resolved
alphastats/llm/uniprot_utils.py Show resolved Hide resolved
alphastats/llm/uniprot_utils.py Show resolved Hide resolved
alphastats/loader/generic_loader.py Show resolved Hide resolved
alphastats/llm/uniprot_utils.py Outdated Show resolved Hide resolved
boopthesnoot
boopthesnoot approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@boopthesnoot boopthesnoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alphastats/gui/pages/06_LLM.py Show resolved Hide resolved
alphastats/llm/uniprot_utils.py Outdated Show resolved Hide resolved
boopthesnoot
boopthesnoot approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@boopthesnoot boopthesnoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JuliaS92 and others added 7 commits November 25, 2024 10:36
@JuliaS92 @boopthesnoot
Simplify parsing of the protein name
01ecbbd 
Co-authored-by: Mikhail Lebedev <43930860+boopthesnoot@users.noreply.github.com>
@JuliaS92 @boopthesnoot
ClassNameCapital
e9f228a 
Co-authored-by: Mikhail Lebedev <43930860+boopthesnoot@users.noreply.github.com>
@JuliaS92
Add quick fixes and todos addressing comments on #378
adb223e
@JuliaS92
Implement quick wins or add TODOs according to PR comments #379
5dc8f2c
@JuliaS92
TODOs from PR conversation
d34cadc
@JuliaS92
Merge pull request #383 from MannLabs/annotation-retrieval
9b6131a 
Annotation retrieval and textualization
Squashing the whole id feature into one PR, step 1 of two.
@JuliaS92
Merge branch 'idhandling' into idhandling-ii
1e7634a
@JuliaS92 JuliaS92 merged commit f96dc60 into idhandling Nov 25, 2024
1 of 5 checks passed
@JuliaS92 JuliaS92 deleted the idhandling-ii branch November 25, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschwoer mschwoer mschwoer left review comments

@boopthesnoot boopthesnoot boopthesnoot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuliaS92 @boopthesnoot @mschwoer