Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search-mr): Fix the searchMergeRequestByUrl function to handle /-/ in the URL #62

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

M0nkeySan
Copy link
Collaborator

The mergeRequestfixture was incorrect, the URL of a MR is build like this :

http://gitlab.example.com/my-group/my-project/-/merge_requests/1 instead of http://gitlab.example.com/my-group/my-project/merge_requests/1

I fixed the retrievement of the projectPath to handle the additional /-/

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.40%. Comparing base (f470aaa) to head (2571bf8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   78.40%   78.40%           
=======================================
  Files          94       94           
  Lines        1922     1922           
  Branches      347      347           
=======================================
  Hits         1507     1507           
  Misses        387      387           
  Partials       28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greg0ire greg0ire merged commit 14e74f4 into ManoManoTech:main Oct 31, 2024
3 checks passed
@greg0ire greg0ire added the bug Something isn't working label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants