Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose Error Handling #1031

Merged
merged 7 commits into from
Mar 5, 2023
Merged

Verbose Error Handling #1031

merged 7 commits into from
Mar 5, 2023

Conversation

ferrell-code
Copy link
Contributor

@ferrell-code ferrell-code commented Mar 2, 2023

Description

  • Deletes suspend manta-pay. This is because the suspender in its current form cannot work due to the transactional nature of extrinsics. If an extrinsic fails all storage changes are rolled back including pausing manta-pay.
  • Adds lots of errors to be more specific
  • Moves error handling logic to its own file to be more tidy

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code ferrell-code added A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta-pay Area: Issues and PRs related to the MantaPay Pallet L-changed Log: Issues and PRs related to changes labels Mar 2, 2023
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code ferrell-code added the C-enhancement Category: An issue proposing an enhancement or a PR with one label Mar 2, 2023
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
ghzlatarev
ghzlatarev previously approved these changes Mar 4, 2023
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
ghzlatarev
ghzlatarev previously approved these changes Mar 5, 2023
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ghzlatarev ghzlatarev requested a review from zqhxuyuan March 5, 2023 14:30
@ghzlatarev ghzlatarev merged commit b1ef342 into manta Mar 5, 2023
@ghzlatarev ghzlatarev deleted the fer-verbose-error branch March 5, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta-pay Area: Issues and PRs related to the MantaPay Pallet C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants