-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verbose Error Handling #1031
Merged
Merged
Verbose Error Handling #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles Ferrell <charlie@manta.network>
ferrell-code
added
A-calamari
Area: Issues and PRs related to the Calamari Runtime
A-dolphin
Area: Issues and PRs related to the Dolphin Runtime
A-manta-pay
Area: Issues and PRs related to the MantaPay Pallet
L-changed
Log: Issues and PRs related to changes
labels
Mar 2, 2023
Signed-off-by: Charles Ferrell <charlie@manta.network>
ferrell-code
added
the
C-enhancement
Category: An issue proposing an enhancement or a PR with one
label
Mar 2, 2023
Signed-off-by: Charles Ferrell <charlie@manta.network>
ferrell-code
commented
Mar 2, 2023
ferrell-code
requested review from
ghzlatarev,
bhgomes,
SupremoUGH,
zqhxuyuan and
Garandor
March 2, 2023 22:35
zqhxuyuan
reviewed
Mar 3, 2023
ghzlatarev
reviewed
Mar 3, 2023
Signed-off-by: Charles Ferrell <charlie@manta.network>
ghzlatarev
previously approved these changes
Mar 4, 2023
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
ghzlatarev
previously approved these changes
Mar 5, 2023
Signed-off-by: Charles Ferrell <charlie@manta.network>
ghzlatarev
approved these changes
Mar 5, 2023
zqhxuyuan
approved these changes
Mar 5, 2023
bhgomes
approved these changes
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-calamari
Area: Issues and PRs related to the Calamari Runtime
A-dolphin
Area: Issues and PRs related to the Dolphin Runtime
A-manta-pay
Area: Issues and PRs related to the MantaPay Pallet
C-enhancement
Category: An issue proposing an enhancement or a PR with one
L-changed
Log: Issues and PRs related to changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
,A-dolphin
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.