Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction fees bump #1047

Merged
merged 18 commits into from
Mar 21, 2023
Merged

Transaction fees bump #1047

merged 18 commits into from
Mar 21, 2023

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Mar 18, 2023 •
edited
Loading

Description

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@ghzlatarev
Bump costs
8366ed9 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Combine growth tests
2d7510d 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Add a cooldown test
c6f181a 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Update runtimes and comments
704381b 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Update runtimes and comments
e45ac62 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Clean up
742d71c 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
ghzlatarev
ghzlatarev commented Mar 18, 2023
View reviewed changes
runtime/common/src/lib.rs Outdated Show resolved Hide resolved
@ghzlatarev
Remove ignores and cleanup
8ed92ef 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
ghzlatarev
ghzlatarev commented Mar 18, 2023
View reviewed changes
runtime/common/src/lib.rs Outdated Show resolved Hide resolved
@ghzlatarev ghzlatarev self-assigned this Mar 18, 2023
@ghzlatarev ghzlatarev added A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime L-fixed Log: Issues and PRs related to bug fixes C-enhancement Category: An issue proposing an enhancement or a PR with one labels Mar 18, 2023
ghzlatarev and others added 2 commits March 18, 2023 16:31
@ghzlatarev
Fix linter
2dc25b3 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Merge branch 'manta' into ghzlatarev/tx-fees-bump
4bac946
@ghzlatarev ghzlatarev marked this pull request as ready for review March 18, 2023 14:34
ferrell-code
ferrell-code reviewed Mar 19, 2023
View reviewed changes
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable to me

runtime/calamari/src/lib.rs Outdated Show resolved Hide resolved
@ghzlatarev
Revert weight2fee and txlen coefficients and update minimummultiplier…
e8f84cf 
… and growth factor

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Use f32 for divisions
1026afc 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Update test to not stop before a day and update budget to 100k
6149f6c 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev requested a review from ferrell-code March 20, 2023 20:45
@ghzlatarev
PR comments
832136a 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Use DAYS constant
2e1616e 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Clean up
daf9986 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Garandor
Garandor previously approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@Garandor Garandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

stechu
stechu previously approved these changes Mar 21, 2023
View reviewed changes
@ghzlatarev
Update adjvar and minmultiplier
315556e 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Account for 1x and 1 day
a819eb0 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev dismissed stale reviews from stechu and Garandor via a819eb0 March 21, 2023 18:38
@ghzlatarev
Account for 1x and 1 day
a418bae 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev requested review from Garandor and stechu March 21, 2023 18:41
@ghzlatarev ghzlatarev merged commit 9e0c6ee into manta Mar 21, 2023
@ghzlatarev ghzlatarev deleted the ghzlatarev/tx-fees-bump branch March 21, 2023 21:31
@ferrell-code ferrell-code mentioned this pull request Apr 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrell-code ferrell-code ferrell-code approved these changes

@Garandor Garandor Garandor approved these changes

@stechu stechu stechu approved these changes

@Dengjianping Dengjianping Awaiting requested review from Dengjianping

@zqhxuyuan zqhxuyuan Awaiting requested review from zqhxuyuan

Assignees

@ghzlatarev ghzlatarev

Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ghzlatarev @stechu @Garandor @ferrell-code