Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCMP, xTokens, Assets, AssetManager and Treasury for Manta #1050

Merged
merged 25 commits into from
Apr 6, 2023

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Mar 21, 2023

Description

Adds the following functionalities on Manta parachain, in order to start connecting to sibling chains and suporting their assets:

  • XCMP queue for parachain to parachain communication and related XCM configurations

  • Assets for supporting foreign chain assets

  • Asset Manager to manage the aforementioned assets

  • xTokens for cross-chain assets transfers

  • Weights of new pallets benchmarked with https://github.com/Manta-Network/Manta/actions/runs/4545375784

  • Moved some test only code to runtime/common and reusing it between all runtimes


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev added A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition labels Mar 22, 2023
@ghzlatarev ghzlatarev self-assigned this Mar 22, 2023
@ghzlatarev ghzlatarev changed the title Ghzlatarev/manta xcm XCMP, Assets, AssetManager and Treasury for Manta Mar 22, 2023
runtime/manta/src/lib.rs Outdated Show resolved Hide resolved
runtime/manta/src/lib.rs Outdated Show resolved Hide resolved
@ghzlatarev ghzlatarev changed the title XCMP, Assets, AssetManager and Treasury for Manta XCMP, xTokens, Assets, AssetManager and Treasury for Manta Mar 22, 2023
ghzlatarev and others added 8 commits March 24, 2023 09:48
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev added the A-calamari Area: Issues and PRs related to the Calamari Runtime label Mar 28, 2023
ghzlatarev and others added 3 commits March 28, 2023 19:23
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev marked this pull request as ready for review March 28, 2023 19:56
@ghzlatarev ghzlatarev requested a review from Garandor March 28, 2023 19:59
@ghzlatarev ghzlatarev requested review from zqhxuyuan and stechu March 28, 2023 19:59
@github-actions
Copy link

github-actions bot commented Mar 28, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev requested a review from zqhxuyuan March 29, 2023 09:21
runtime/manta/src/lib.rs Outdated Show resolved Hide resolved
runtime/manta/tests/xcm_mock/mod.rs Show resolved Hide resolved
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev requested a review from ferrell-code April 4, 2023 13:17
ghzlatarev and others added 2 commits April 4, 2023 16:17
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
ferrell-code
ferrell-code previously approved these changes Apr 4, 2023
runtime/manta/src/lib.rs Outdated Show resolved Hide resolved
runtime/manta/src/lib.rs Outdated Show resolved Hide resolved
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@Garandor Garandor merged commit f319bcc into manta Apr 6, 2023
@Garandor Garandor deleted the ghzlatarev/manta-xcm branch April 6, 2023 13:52
@Dengjianping Dengjianping mentioned this pull request Apr 10, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants