Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stress benchmark test #1078

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Apr 14, 2023

Description

  • Regenerate stress benchamark after circuit change
  • Uncomment CI test

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev self-assigned this Apr 14, 2023
@ghzlatarev ghzlatarev added C-enhancement Category: An issue proposing an enhancement or a PR with one A-calamari Area: Issues and PRs related to the Calamari Runtime A-ci Area: Continuous Integration A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-testing Area: Testing-related Issues and PRs A-manta-pay Area: Issues and PRs related to the MantaPay Pallet L-fixed Log: Issues and PRs related to bug fixes labels Apr 14, 2023
@github-actions
Copy link

github-actions bot commented Apr 14, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

@ghzlatarev ghzlatarev marked this pull request as ready for review April 17, 2023 03:36
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, could add it to manta integration tests too, can be separate PR

@ghzlatarev
Copy link
Contributor Author

Nice, could add it to manta integration tests too, can be separate PR

Jamie is on that.

@Dengjianping
Copy link
Contributor

Nice, could add it to manta integration tests too, can be separate PR

Jamie is on that.

I suppose the precomputed files can be reused for manta, right?

@ghzlatarev
Copy link
Contributor Author

ghzlatarev commented Apr 19, 2023

Nice, could add it to manta integration tests too, can be separate PR

Jamie is on that.

I suppose the precomputed files can be reused for manta, right?

Sorry I misunderstood Charlie's comment. There's no MantaPay on Manta yet, so can't use it now. I'll enable it when it's ready.

@ghzlatarev ghzlatarev merged commit 74ff256 into manta Apr 19, 2023
@ghzlatarev ghzlatarev deleted the ghzlatarev/reenable-stress-benchamrk branch April 19, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-ci Area: Continuous Integration A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta-pay Area: Issues and PRs related to the MantaPay Pallet A-testing Area: Testing-related Issues and PRs C-enhancement Category: An issue proposing an enhancement or a PR with one L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants