Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UtxoAccumulator from MantaSbt #1125

Merged
merged 5 commits into from
Jun 1, 2023
Merged

Conversation

ferrell-code
Copy link
Contributor

@ferrell-code ferrell-code commented May 25, 2023

Description

Removes UtxoAccumulatorOutputs from pallet-sbt. It is not needed as it is only used for spending assets.


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code ferrell-code changed the title Remove UtxoAccumulator MantaSbt Remove UtxoAccumulator from MantaSbt May 25, 2023
@ferrell-code ferrell-code added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-runtime Area: Issues and PRs related to Runtimes C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-fixed Log: Issues and PRs related to bug fixes labels May 25, 2023
@github-actions
Copy link

github-actions bot commented May 25, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

@ghzlatarev ghzlatarev requested a review from Dengjianping June 1, 2023 06:04
@Dengjianping Dengjianping merged commit fa10f39 into manta Jun 1, 2023
@Dengjianping Dengjianping deleted the fer-remove-utxo-acc branch June 1, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants