Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mantapay to manta runtime #1137

Merged
merged 14 commits into from
Jun 5, 2023
Merged

Add mantapay to manta runtime #1137

merged 14 commits into from
Jun 5, 2023

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented May 31, 2023

Description

  • mantapay rpc performance tests and correctness tests will be added by another pr

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime A-manta-pay Area: Issues and PRs related to the MantaPay Pallet L-added Log: Issues and PRs related to addition labels May 31, 2023
@Dengjianping Dengjianping self-assigned this May 31, 2023
@Dengjianping Dengjianping marked this pull request as ready for review June 1, 2023 14:05
node/src/command.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, one comment

node/src/rpc/mod.rs Outdated Show resolved Hide resolved
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Copy link
Contributor

@ghzlatarev ghzlatarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, please runt he SDK examples once against a local node just to make sure everything works (in case you havent')

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

ghzlatarev and others added 4 commits June 2, 2023 19:59
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ghzlatarev
Copy link
Contributor

nice one @ferrell-code

ghzlatarev and others added 4 commits June 4, 2023 13:55
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@Dengjianping
Copy link
Contributor Author

Looking good, please runt he SDK examples once against a local node just to make sure everything works (in case you havent')

It' done with Danial's help.

image

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
ghzlatarev
ghzlatarev previously approved these changes Jun 5, 2023
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev merged commit 7bf8ad4 into manta Jun 5, 2023
@ghzlatarev ghzlatarev deleted the add-mantapay-to-manta branch June 5, 2023 14:25
@ghzlatarev ghzlatarev linked an issue Jun 19, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-manta Area: Issues and PRs related to the Manta Runtime A-manta-pay Area: Issues and PRs related to the MantaPay Pallet C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure mantapay for manta runtime
3 participants