Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire dolphin runtime #1167

Merged
merged 19 commits into from
Jul 3, 2023
Merged

Retire dolphin runtime #1167

merged 19 commits into from
Jul 3, 2023

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Jun 20, 2023

Description

closes: #958

  • Retire all Dolphin runtime related code, as it is not longer used for anything.
  • check-tests was excluding pallet-manta-pay tests, when we only wanted to exclude the benchmark unit test (as our code relies on externally passed chain-spec file) . The fix is to not exclude in the CI but just hard-code disable the benchmark unit tests in the pallet code.
  • gov v2 imports are required because of upstream code, so moved them outside of integrations test crate, as that crate is excluded in our unit tests job and it will fail compilation

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev self-assigned this Jun 20, 2023
@ghzlatarev ghzlatarev requested review from zqhxuyuan, Garandor, Dengjianping, Apokalip and ferrell-code and removed request for zqhxuyuan June 20, 2023 08:11
@ghzlatarev ghzlatarev added L-removed Log: Issues and PRs related to removing something C-enhancement Category: An issue proposing an enhancement or a PR with one A-runtime Area: Issues and PRs related to Runtimes A-dolphin Area: Issues and PRs related to the Dolphin Runtime labels Jun 20, 2023
@ghzlatarev
Copy link
Contributor Author

cargo clippy seems to be broken with any rust version

@Dengjianping
Copy link
Contributor

And we might delete dolphin docs from our manta docs

@Dengjianping
Copy link
Contributor

Dengjianping commented Jun 20, 2023

And some dolphin genesis files should be deleted

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@github-actions
Copy link

github-actions bot commented Jun 23, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

ghzlatarev and others added 4 commits June 24, 2023 06:12
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@github-actions
Copy link

github-actions bot commented Jun 26, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above target_daily_congestion_cost_kma

@github-actions
Copy link

github-actions bot commented Jun 26, 2023

⚠️ Congestion test: 1-day congestion cost (manta-runtime) is NOT above target_daily_congestion_cost_kma

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ci still seems to be failing

ghzlatarev and others added 3 commits June 29, 2023 16:33
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Copy link
Contributor Author

looks good ci still seems to be failing

Yeah i see why.
Something from upstream pulls the gov v2 pallets, which require us to also include them.
But if we include them in the integrations-test crate (and exclude it in the unit tests) then it won't compile.

This actually showed that we had broken our unit tests in another way. We wanted to exclude the manta-pay benchmarking unit test, but we had excluded all the unit tests. Fixed this now.

@ghzlatarev ghzlatarev requested a review from ferrell-code June 30, 2023 09:27
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
runtime/calamari/Cargo.toml Show resolved Hide resolved
@Dengjianping
Copy link
Contributor

I thought we would have faster ci check once dolphin runtime.
By the way, not sure it will affect change log generation, the dolphin tag [DO]. I suppose it won't.

@ghzlatarev
Copy link
Contributor Author

ghzlatarev commented Jul 3, 2023

I thought we would have faster ci check once dolphin runtime. By the way, not sure it will affect change log generation, the dolphin tag [DO]. I suppose it won't.

no, we stopped Dolphin jobs some time ago already. This is just to reduce code base -8000 lines feels good

also re-includes mantapay in the unit tests job as they were not running for a few days

@ghzlatarev ghzlatarev merged commit b9ba5c6 into manta Jul 3, 2023
@ghzlatarev ghzlatarev deleted the ghzlatarev/retire-dolphin branch July 3, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-runtime Area: Issues and PRs related to Runtimes C-enhancement Category: An issue proposing an enhancement or a PR with one L-removed Log: Issues and PRs related to removing something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retire Dolphin Runtime
4 participants