-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retire dolphin runtime #1167
Retire dolphin runtime #1167
Conversation
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
cargo clippy seems to be broken with any rust version |
And we might delete dolphin docs from our manta docs |
And some dolphin genesis files should be deleted |
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
|
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
|
|
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good ci still seems to be failing
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Yeah i see why. This actually showed that we had broken our unit tests in another way. We wanted to exclude the manta-pay benchmarking unit test, but we had excluded all the unit tests. Fixed this now. |
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
I thought we would have faster ci check once dolphin runtime. |
no, we stopped Dolphin jobs some time ago already. This is just to reduce code base -8000 lines feels good also re-includes mantapay in the unit tests job as they were not running for a few days |
Description
closes: #958
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.