-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy Name Service Pallet #1179
Copy Name Service Pallet #1179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if all the Cargo.lock changes are needed, looks good
@ferrell-code should I just remove the cargo.lock changes fully? |
|
|
Nah I think it is good as is |
Note name service is not in manta runtime, that can be separate PR |
Yeah, Calamari is just for testing. For manta I would prefer if we have actual pricing, but I'm kind of waiting on that part |
Description
Copied Name Service Pallet fixing DCO issue
#1154 #1154
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.