Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Name Service Pallet #1179

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Copy Name Service Pallet #1179

merged 1 commit into from
Jun 29, 2023

Conversation

Apokalip
Copy link
Contributor

@Apokalip Apokalip commented Jun 28, 2023

Description

Copied Name Service Pallet fixing DCO issue

#1154 #1154

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Apokalip <simeon@manta.network>
@Apokalip Apokalip added C-enhancement Category: An issue proposing an enhancement or a PR with one A-calamari Area: Issues and PRs related to the Calamari Runtime A-development Area: Development Resources and Upgrades L-added Log: Issues and PRs related to addition labels Jun 28, 2023
@Apokalip Apokalip self-assigned this Jun 28, 2023
@Apokalip Apokalip linked an issue Jun 28, 2023 that may be closed by this pull request
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if all the Cargo.lock changes are needed, looks good

@Apokalip
Copy link
Contributor Author

Not sure if all the Cargo.lock changes are needed, looks good

@ferrell-code should I just remove the cargo.lock changes fully?

@github-actions
Copy link

github-actions bot commented Jun 28, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above target_daily_congestion_cost_kma

@github-actions
Copy link

github-actions bot commented Jun 28, 2023

⚠️ Congestion test: 1-day congestion cost (manta-runtime) is NOT above target_daily_congestion_cost_kma

@Apokalip Apokalip requested a review from Garandor June 28, 2023 16:09
@ferrell-code
Copy link
Contributor

Not sure if all the Cargo.lock changes are needed, looks good

@ferrell-code should I just remove the cargo.lock changes fully?

Nah I think it is good as is

@ferrell-code
Copy link
Contributor

Note name service is not in manta runtime, that can be separate PR

@Apokalip
Copy link
Contributor Author

Note name service is not in manta runtime, that can be separate PR

Yeah, Calamari is just for testing. For manta I would prefer if we have actual pricing, but I'm kind of waiting on that part

@ghzlatarev ghzlatarev merged commit fb04910 into manta Jun 29, 2023
@ghzlatarev ghzlatarev deleted the name_service_pallet_2 branch June 29, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-development Area: Development Resources and Upgrades C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name Service
3 participants