Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release binary building #1220

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Fix release binary building #1220

merged 4 commits into from
Jul 18, 2023

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented Jul 16, 2023

Description

  1. Bump srtool from 0.4 to 0.7.
  2. Rollback stable rust to 1.69. I tried 1.71(just released last week), it has the same problem.

Closes #1098 #1158


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping self-assigned this Jul 16, 2023
@Dengjianping Dengjianping added C-bug Category: Issues documenting a bug A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-automation Area: Issues and PRs related to Automation A-ci Area: Continuous Integration L-fixed Log: Issues and PRs related to bug fixes labels Jul 16, 2023
@Dengjianping Dengjianping marked this pull request as ready for review July 17, 2023 02:04
@Dengjianping Dengjianping changed the title Bump srtool and use rust 1.69 for building binary Fix release binary building Jul 17, 2023
@Dengjianping
Copy link
Contributor Author

I did runtime upgrade with this draft build, and started a whole new network, it worked.

@github-actions
Copy link

github-actions bot commented Jul 17, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

Copy link
Contributor

@ghzlatarev ghzlatarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, can you change it in the runtime-upgrade workflow as well

@ghzlatarev
Copy link
Contributor

I guess also spawn an issue to change to 1.71 at some point (add to Pending pipeline)

@github-actions
Copy link

github-actions bot commented Jul 17, 2023

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

@Dengjianping
Copy link
Contributor Author

Nice, can you change it in the runtime-upgrade workflow as well

I found this workflow doesn't need to build any binary.

@ghzlatarev
Copy link
Contributor

ghzlatarev commented Jul 17, 2023

Nice, can you change it in the runtime-upgrade workflow as well

I found this workflow doesn't need to build any binary.

Yeah it downloads a binary that the user provides but uses srtool for the runtimes.
There might be a different problem there but let's still update sr-tool.

Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool we still should remember to periodically bump the sr tool to the latest version

@Dengjianping Dengjianping merged commit 348029c into manta Jul 18, 2023
@Dengjianping Dengjianping deleted the fix-binary-building branch July 18, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-automation Area: Issues and PRs related to Automation A-calamari Area: Issues and PRs related to the Calamari Runtime A-ci Area: Continuous Integration A-manta Area: Issues and PRs related to the Manta Runtime C-bug Category: Issues documenting a bug L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
3 participants