Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment MantaPay RPC correctness and performance tests #1221

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Jul 17, 2023

Description

  • Enable MantaPay RPC correctness and performance tests

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev added A-manta Area: Issues and PRs related to the Manta Runtime A-ci Area: Continuous Integration C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-changed Log: Issues and PRs related to changes labels Jul 17, 2023
@ghzlatarev ghzlatarev self-assigned this Jul 17, 2023
@ghzlatarev ghzlatarev linked an issue Jul 17, 2023 that may be closed by this pull request
@ghzlatarev ghzlatarev marked this pull request as ready for review July 17, 2023 06:21
@github-actions
Copy link

github-actions bot commented Jul 17, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

@github-actions
Copy link

github-actions bot commented Jul 17, 2023

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

@ghzlatarev ghzlatarev mentioned this pull request Jul 17, 2023
5 tasks
@Dengjianping Dengjianping merged commit 1fd9afb into manta Jul 18, 2023
@Dengjianping Dengjianping deleted the ghzlatarev/manta-rpc-correctnes-and-perf-test branch July 18, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: Continuous Integration A-manta Area: Issues and PRs related to the Manta Runtime C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MantaPay RPC tests for Manta runtime
3 participants