-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block outgoing MANTA transfers on the XCM instruction level #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
ghzlatarev
added
C-enhancement
Category: An issue proposing an enhancement or a PR with one
A-manta
Area: Issues and PRs related to the Manta Runtime
A-calamari
Area: Issues and PRs related to the Calamari Runtime
A-xcm
Area: Issues and PRs related to Cross-Consensus Messaging (XCM)
L-changed
Log: Issues and PRs related to changes
labels
Jul 17, 2023
|
✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost |
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
ghzlatarev
changed the title
Add more instructions to AllowUnpaidExecutionFrom
Block outgoing MANTA transfers on the XCM instruction level
Jul 18, 2023
ghzlatarev
requested review from
zqhxuyuan,
Dengjianping,
Apokalip,
ferrell-code and
Garandor
July 18, 2023 05:22
Dengjianping
approved these changes
Jul 19, 2023
Apokalip
approved these changes
Jul 19, 2023
Garandor
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-calamari
Area: Issues and PRs related to the Calamari Runtime
A-manta
Area: Issues and PRs related to the Manta Runtime
A-xcm
Area: Issues and PRs related to Cross-Consensus Messaging (XCM)
C-enhancement
Category: An issue proposing an enhancement or a PR with one
L-changed
Log: Issues and PRs related to changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TransferReserveAsset
instruction with a top level paid XCM message.AllowTopLevelPaidExecutionFrom
andAllowTopLevelPaidExecutionDescendOriginFirst
barriers to check for theTransferReserveAsset
instruction after theBuyExecution
and return error if it is present in the messageBefore we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.