Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zombienet migration #1237

Merged
merged 38 commits into from
Aug 11, 2023
Merged

Zombienet migration #1237

merged 38 commits into from
Aug 11, 2023

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented Jul 27, 2023 •
edited
Loading

Description

Closes #680

  • metadata diff
  • runtime upgrade
  • integration test - manta
  • integration test - calamari

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@Dengjianping
[no ci]Zombienet migration
66cb4b2 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping self-assigned this Jul 27, 2023
@Dengjianping Dengjianping added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-automation Area: Issues and PRs related to Automation A-ci Area: Continuous Integration A-testing Area: Testing-related Issues and PRs L-added Log: Issues and PRs related to addition L-deprecated Log: Issues and PRs related to deprication labels Jul 27, 2023
@Dengjianping
[no ci]Use zombienet for metadata diff
f788790 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
[no ci]Add metadata diff toml
fb0d1dc 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
[no ci]change directory
5181f24 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
[no ci]Change path
15f04f1 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
[no ci]Change port
783ecb1 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
[no ci]Sipport manta metadata diff
1f3c3e5 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
[no ci]Fix ci
38e928e 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
[no ci]Fix ci
24d4c1b 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
[no ci]Fix toml path
0bf6610 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
[no ci]Use dasel for editing toml file
c700054 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Replace polkadot-launch with zombienet for the rest of workflows
6a3810d 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping marked this pull request as ready for review August 7, 2023 09:42
@Dengjianping
Remove unused polkadot-launch config files
1907df2 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Merge manta branch
dffc46d 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping added the C-cleanup Category: Issues documenting cleanup or PRs that clean code up label Aug 7, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023 •
edited
Loading

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

@github-actions
Copy link

github-actions bot commented Aug 7, 2023 •
edited
Loading

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

@Dengjianping
Fix fmt and some ci errors
9a069e4 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Fix ci
659b33f 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Fix path
9c163fb 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping added the L-changed Log: Issues and PRs related to changes label Aug 9, 2023
@Dengjianping
cache npm
ac1abd4 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Do not cache npm
925a4ad 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Install pm2
d473af8 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Fix manta integration ci and change ws port
364ae0b 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Fix zndsl path and change port
8519f18 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Fix manta integration tests
facf27d 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Fix stress tests
555d2c1 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Add dasel to env path
707076d 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Update chain id for manta integration tests
41fa844 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Debug manta integration tests
b947219 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Debug manta integration tests
5a85318 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Debug manta integration tests
b0d4308 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Debug manta integration tests
342146d 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Debug manta integration tests
11f8a52 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Debug manta integration tests
c1a0a03 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping
Fix path
0bafe88 
Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping removed L-added Log: Issues and PRs related to addition L-deprecated Log: Issues and PRs related to deprication labels Aug 10, 2023
ferrell-code
ferrell-code approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe want to let #1242 merge first, lgtm

@Dengjianping
Copy link
Contributor Author

totally agreed

@Dengjianping Dengjianping requested a review from Garandor August 11, 2023 02:47
ghzlatarev
ghzlatarev approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@ghzlatarev ghzlatarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greagt! Can you organize a meeting and demo this please.

@ghzlatarev ghzlatarev merged commit 0814f5d into manta Aug 11, 2023
@ghzlatarev ghzlatarev deleted the zombienet branch August 11, 2023 04:39
@Dengjianping
Copy link
Contributor Author

Greagt! Can you organize a meeting and demo this please.

sure, I will

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrell-code ferrell-code ferrell-code approved these changes

@ghzlatarev ghzlatarev ghzlatarev approved these changes

@zqhxuyuan zqhxuyuan Awaiting requested review from zqhxuyuan

@Apokalip Apokalip Awaiting requested review from Apokalip

@Garandor Garandor Awaiting requested review from Garandor

Assignees

@Dengjianping Dengjianping

Labels
A-automation Area: Issues and PRs related to Automation A-calamari Area: Issues and PRs related to the Calamari Runtime A-ci Area: Continuous Integration A-manta Area: Issues and PRs related to the Manta Runtime A-testing Area: Testing-related Issues and PRs C-cleanup Category: Issues documenting cleanup or PRs that clean code up C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TENTATIVE: Retire polkadot-launch for zombienet
3 participants
@Dengjianping @ghzlatarev @ferrell-code