Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup to #601 #634

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Fixup to #601 #634

merged 1 commit into from
Jun 29, 2022

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Jun 28, 2022

I missed a step of the docs when i created #601.
Org-Level projects are not the same as Repo-Level projects and so it fails with
https://github.com/Manta-Network/Manta/runs/7098777493?check_suite_focus=true#step:3:9

@bhgomes Could you when you get the chance create a ORG_ISSUE_GITHUB_TOKEN on the Manta-Network Organisation and add it to this repo's secrets as described below:
-> https://github.com/srggrs/assign-one-project-github-action#organisation-or-user-project

Signed-off-by: Adam Reif garandor@manta.network

Description

closes: #599


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Added one line describing your change in <branch>/CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@Garandor Garandor self-assigned this Jun 28, 2022
@Garandor Garandor added the A-ci Area: Continuous Integration label Jun 28, 2022
@Garandor Garandor added this to the v3.2.1 milestone Jun 28, 2022
@Garandor Garandor requested review from bhgomes and BoyuanFeng June 28, 2022 20:47
@ghzlatarev ghzlatarev merged commit 58b6f80 into manta Jun 29, 2022
@ghzlatarev ghzlatarev deleted the garandor/601-fixup branch June 29, 2022 07:12
Garandor pushed a commit that referenced this pull request Jul 1, 2022
Signed-off-by: Adam Reif <garandor@manta.network>
bhgomes pushed a commit that referenced this pull request Jul 1, 2022
Signed-off-by: Adam Reif <garandor@manta.network>
stechu pushed a commit that referenced this pull request Jul 11, 2022
https://github.com/srggrs/assign-one-project-github-action#organisation-or-user-project

Signed-off-by: Adam Reif <garandor@manta.network>
Signed-off-by: Shumo Chu <shumo.chu@pm.me>
stechu pushed a commit that referenced this pull request Jul 11, 2022
Signed-off-by: Adam Reif <garandor@manta.network>
Signed-off-by: Shumo Chu <shumo.chu@pm.me>
@Apokalip Apokalip added the L-fixed Log: Issues and PRs related to bug fixes label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: Continuous Integration L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking: Improve Dev Tooling
5 participants