-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change QA workflow link to internal Notion #766
Conversation
Please signoff on all commits with your name, email and gpg key for the Developer's Certificate of Origin. |
c19e073
to
c52d70b
Compare
While you're at this, can you also add a few things:
|
Signed-off-by: Adam Reif <Garandor@manta.network>
6279445
to
8a3c2b6
Compare
oh shit i just forcepushed an old state and threw away all of my changes |
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor we can also decide whether to get rid of the Moonbase-Relay chain during planning. Basically all the nodes somehow dropped because of some backend AWS thing (not exactly sure what, but it wasn't a blockchain thing). And now we have to involve moonbeam people to restart us, and i'm not sure whether we should bother them. |
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Description
Fix the label checker workflow to rerun when a PR is labeled and not just on push
Update QA template with lessons learned from v3.3.0 release
relates to #599
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
L-
group to this PRA-
andC-
groups to this PRFiles changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.yml
workflow for help. If this number is updated, then thespec_version
must also be updated