-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update genesis #952
Merged
Merged
update genesis #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garandor
force-pushed
the
garandor/manta-genesis
branch
from
December 28, 2022 18:55
6ab00cc
to
082a605
Compare
Garandor
added
C-enhancement
Category: An issue proposing an enhancement or a PR with one
A-manta
Area: Issues and PRs related to the Manta Runtime
L-added
Log: Issues and PRs related to addition
labels
Dec 28, 2022
Garandor
requested review from
ghzlatarev,
Dengjianping and
ferrell-code
and removed request for
ghzlatarev
December 29, 2022 00:14
Garandor
commented
Dec 29, 2022
Garandor
commented
Dec 29, 2022
Garandor
force-pushed
the
garandor/manta-genesis
branch
from
December 29, 2022 05:13
f15aaf6
to
0617bc2
Compare
flame4
previously approved these changes
Dec 29, 2022
- Parachain ID 2100 - production keys - move `from_seed_unchecked` from primitives into runtime, Manta RT has 2 keys, Calamari/Dolphin have AuraId as extra key - remove service_aura since manta RT no longer uses it Signed-off-by: Adam Reif <Garandor@manta.network>
Garandor
force-pushed
the
garandor/manta-genesis
branch
from
December 29, 2022 16:01
3b37573
to
f346141
Compare
ferrell-code
approved these changes
Dec 29, 2022
grenade
approved these changes
Dec 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all verified (c1 - c5, node, collator, nimbus, vrf).
zqhxuyuan
reviewed
Dec 30, 2022
zqhxuyuan
reviewed
Dec 30, 2022
zqhxuyuan
reviewed
Dec 30, 2022
zqhxuyuan
approved these changes
Dec 30, 2022
SupremoUGH
pushed a commit
that referenced
this pull request
Jan 10, 2023
- Parachain ID 2100 - production keys - move `from_seed_unchecked` from primitives into runtime, Manta RT has 2 keys, Calamari/Dolphin have AuraId as extra key - remove service_aura since manta RT no longer uses it Signed-off-by: Adam Reif <Garandor@manta.network> Signed-off-by: Adam Reif <Garandor@manta.network> Signed-off-by: SupremoUGH <francisco@manta.network>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-manta
Area: Issues and PRs related to the Manta Runtime
C-enhancement
Category: An issue proposing an enhancement or a PR with one
L-added
Log: Issues and PRs related to addition
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
relates to OR closes: #926
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
,A-dolphin
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.yml
workflow for help. If this number is updated, then thespec_version
must also be updated