Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trivial: fix badge + remove mention of milestone from PR template #954

Merged
merged 4 commits into from
Dec 29, 2022

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Dec 29, 2022

Signed-off-by: Adam Reif Garandor@manta.network

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • This PR is targeted against the current Milestone ( otherwise discuss if it can be added in time)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics

@Garandor Garandor self-assigned this Dec 29, 2022
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor added C-bug Category: Issues documenting a bug A-development Area: Development Resources and Upgrades E-minutes few minutes of effort, trivial change L-skip Log: Will be skipped on changelog generation and removed E-minutes few minutes of effort, trivial change labels Dec 29, 2022
@Garandor Garandor marked this pull request as ready for review December 29, 2022 05:50
@Garandor Garandor changed the title fix badge trivial: fix badge Dec 29, 2022
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor changed the title trivial: fix badge trivial: fix badge + remove mention of milestone from PR template Dec 29, 2022
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor requested a review from ghzlatarev December 29, 2022 15:04
@Garandor Garandor merged commit 49a8a0a into manta Dec 29, 2022
@Garandor Garandor deleted the garandor/badgefix branch December 29, 2022 17:20
SupremoUGH pushed a commit that referenced this pull request Jan 10, 2023
* fix badge

Signed-off-by: Adam Reif <Garandor@manta.network>

* remove mention of milestone from PR template

Signed-off-by: Adam Reif <Garandor@manta.network>

* connect issue uses zenhub

Signed-off-by: Adam Reif <Garandor@manta.network>

Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-development Area: Development Resources and Upgrades C-bug Category: Issues documenting a bug L-skip Log: Will be skipped on changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants