xcm fee of native token to treasury #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
zqhxuyuan
added
A-calamari
zqhxuyuan
requested review from
ghzlatarev,
Garandor,
Dengjianping and
ferrell-code
|
Just an idea, should we give some xcm fee share to block producer, just like what we did for transaction fee? |
Dengjianping
reviewed
Jan 9, 2023
ghzlatarev
previously approved these changes
Jan 10, 2023
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Dengjianping
approved these changes
Jan 10, 2023
ferrell-code
approved these changes
Jan 10, 2023
Garandor
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zqhxuyuan zqhxuyuan@gmail.com
Description
closes: #876
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-group to this PRA-andC-groups to this PRA-calamari,A-dolphinand/orA-mantaif your changes are meant for/impact either of these (CI depends on it)Files changedin the Github PR explorer.Situational Notes:
BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]items to check for any.