Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Fastest Poseidon Implementation #22

Closed
Tracked by #40
bhgomes opened this issue Feb 27, 2022 · 1 comment · Fixed by #57
Closed
Tracked by #40

Use Fastest Poseidon Implementation #22

bhgomes opened this issue Feb 27, 2022 · 1 comment · Fixed by #57
Assignees

Comments

@bhgomes
Copy link
Contributor

bhgomes commented Feb 27, 2022

We have a few different Poseidon implementations in the Manta ecosystem and we want to use the fastest one in production. Here are some goals for merging the implementation from Plonk-Prototype:

  • Upgrade posiedon file to directory in manta-pay crate
  • Keep the same interface that is defined in the current poseidon module, just upgrade the implementation (should not need to change any other files in manta-pay after the upgrade)
  • Add tests for consistency with known Poseidon implementations
  • Add in the parameter generation logic into the posiedon module and upgrade the parameters in the bin/generate_parameters.rs file (also remove the Sample implementation since it is not correct)
  • Add a PR to manta-sdk for new parameters

NB: For this PR we only care about the R1CS implementation, not PLONK.

@tsunrise
Copy link
Contributor

I will start this soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants