Feature: Parameter Generation for Poseidon Hash #57

BoyuanFeng · 2022-05-02T22:19:55Z

Integrate from Plonk Prototype to Manta-rs

Major changes:

Extend the Specification trait in manta-pay/src/crypto/hash/poseidon.rs to 1) separate fields for parameters (public constants) and states (private variables); 2) generically support addition, multiplication, etc
Rewrite parameter generation following the Specification trait such that the code can work for generic fields
Update Poseidon hash implementation to match #constraints between manta-rs and Plonk Prototype. Saw 20~30% saving in #constraints and latency than previous manta-rs, in terms of Poseidon hash, mint, reclaim, and private transfer.

Changes in #51 are moved here.
Closes: #22

tsunrise

Just took a very rough look at the code. Have a few comments. Will do it again in a day or two!

manta-pay/src/crypto/hash/poseidon_parameter_generation/constants.rs

manta-pay/src/crypto/hash/poseidon.rs

manta-pay/src/crypto/hash/poseidon_parameter_generation/constants.rs

manta-pay/src/crypto/hash/poseidon_parameter_generation/lfsr.rs

bhgomes

Small review right now, more comments later, but please address the current comments first. Thanks!

manta-pay/src/crypto/hash/mod.rs

manta-pay/src/crypto/hash/poseidon/hasher.rs

manta-pay/src/crypto/hash/poseidon/parameter_generation/lfsr.rs

tsunrise

reviewed hasher and part of lfsr, will take a look at remaining part later

manta-pay/src/crypto/hash/mod.rs

manta-pay/src/crypto/hash/poseidon/hasher.rs

manta-pay/src/crypto/hash/poseidon/parameter_generation/matrix.rs

manta-pay/src/crypto/hash/poseidon/hasher.rs

manta-pay/src/crypto/hash/poseidon/parameter_generation/lfsr.rs

manta-pay/src/crypto/hash/poseidon/hasher.rs

manta-pay/src/crypto/hash/poseidon/parameter_generation/lfsr.rs

manta-pay/src/crypto/hash/poseidon/parameter_generation/matrix.rs

manta-pay/src/crypto/hash/mod.rs

manta-pay/src/crypto/hash/poseidon/parameter_generation/preprocessing.rs

manta-pay/src/crypto/hash/poseidon/parameter_generation/round_constants.rs

manta-pay/src/crypto/hash/poseidon/parameter_generation/round_numbers.rs

tsunrise

nice work! left some minor comments

manta-pay/src/crypto/hash/poseidon/parameter_generation/lfsr.rs

manta-pay/src/crypto/hash/poseidon/parameter_generation/matrix.rs

manta-pay/src/crypto/hash/poseidon/mod.rs

bhgomes · 2022-05-23T14:27:11Z

CI breaking issue: rust-lang/rust-clippy#8867

manta-pay/src/crypto/hash/poseidon/mod.rs

manta-pay/src/crypto/hash/poseidon/parameter_generation/lfsr.rs

manta-pay/src/crypto/hash/poseidon/hasher.rs

tsunrise

LGTM with some minor comments. I pre-approve this so that my review will not block you
(I will make a PR for #74 once this one is merged)

manta-pay/src/crypto/hash/poseidon/parameter/matrix.rs

manta-pay/src/crypto/hash/poseidon/parameter/mds.rs

manta-pay/src/crypto/hash/poseidon/parameter/mod.rs

manta-pay/src/crypto/hash/poseidon/mod.rs

manta-pay/src/crypto/hash/poseidon/parameter/round_numbers.rs

manta-pay/src/crypto/hash/poseidon/parameter/matrix.rs

manta-pay/src/crypto/hash/poseidon/parameter/mod.rs

tsunrise

LGTM

manta-pay/src/crypto/hash/poseidon/round_constants.rs

manta-pay/src/crypto/hash/poseidon/mod.rs

* feat: add proving and verifying benchmark * fix: remove let bindings for clippy false positives Co-authored-by: Brandon H. Gomes <bhgomes@pm.me>

* feat: generalized ledger infrastructure and add correct pruning * feat: add more randomness/concurrency to simulation * feat: add iteration features for manta_util::array * feat: add sign method to separate post into pieces * feat: use more sharding-optimal coin selection algorithm

* feat: add self-transfers to simulation * feat: add GenerateReceivingKeys, FlushToPublic, and SelfTransfer to sim * feat: add zero-transaction to simulation * feat: add simulation action

* initial implementation * support benchmarking verify time * headless wasm timer * headless wasm & clean browser bench code * add conditional compilation * add ci

BoyuanFeng self-assigned this May 2, 2022

tsunrise self-requested a review May 3, 2022 07:51

tsunrise reviewed May 4, 2022

View reviewed changes

tsunrise mentioned this pull request May 4, 2022

Use Poseidon Implementation from plonk-prototype #51

Closed

bhgomes suggested changes May 16, 2022

View reviewed changes

tsunrise mentioned this pull request May 16, 2022

Add poseidon reference implementation (using sage) #67

Closed

tsunrise reviewed May 16, 2022

View reviewed changes

bhgomes reviewed May 17, 2022

View reviewed changes

manta-pay/src/crypto/hash/poseidon/hasher.rs Outdated Show resolved Hide resolved

tsunrise suggested changes May 17, 2022

View reviewed changes

tsunrise reviewed May 22, 2022

View reviewed changes

bhgomes suggested changes May 25, 2022

View reviewed changes

tsunrise previously approved these changes May 28, 2022

View reviewed changes

bhgomes dismissed tsunrise’s stale review via cfdedb1 May 29, 2022 01:11

bhgomes requested review from tsunrise and bhgomes June 2, 2022 02:07

bhgomes previously approved these changes Jun 2, 2022

View reviewed changes

manta-pay/src/crypto/hash/poseidon/parameter/matrix.rs Outdated Show resolved Hide resolved

manta-pay/src/crypto/hash/poseidon/parameter/mod.rs Outdated Show resolved Hide resolved

bhgomes requested review from tsunrise and removed request for tsunrise June 2, 2022 04:10

tsunrise previously approved these changes Jun 2, 2022

View reviewed changes

manta-pay/src/crypto/hash/poseidon/round_constants.rs Outdated Show resolved Hide resolved

tsunrise mentioned this pull request Jun 2, 2022

Move Posiedon Sage Script Here #84

Closed

tsunrise reviewed Jun 2, 2022

View reviewed changes

manta-pay/src/crypto/hash/poseidon/mod.rs Show resolved Hide resolved

BoyuanFeng dismissed stale reviews from tsunrise and bhgomes via 6061df0 June 2, 2022 20:04

BoyuanFeng force-pushed the poseidon_optimization branch from 791640e to 6061df0 Compare June 2, 2022 20:04

boyuan and others added 5 commits June 2, 2022 16:09

initial implementation

f80a99d

Update poseidon.rs

bfaa52f

Update #PARTIAL_ROUNDS

8593061

poseidon parameter generation

cd3b7fe

Extend Specification trait

0b9e873

Boyuan Feng and others added 20 commits June 2, 2022 16:09

feat: add benchmarks (#63)

baa3c4b

* feat: add proving and verifying benchmark * fix: remove let bindings for clippy false positives Co-authored-by: Brandon H. Gomes <bhgomes@pm.me>

cache

0fae8e6

feat: clean a few traits

dbafd0b

Implement MatrixOps

2c00732

feat: increase simulation likelihood of low probability events (#68)

92f05d0

* feat: add self-transfers to simulation * feat: add GenerateReceivingKeys, FlushToPublic, and SelfTransfer to sim * feat: add zero-transaction to simulation * feat: add simulation action

WASM Benchmark (#66)

fd939c4

* initial implementation * support benchmarking verify time * headless wasm timer * headless wasm & clean browser bench code * add conditional compilation * add ci

resolve comments

99cd91c

add lfsr doc

76dc23a

fix: remove the package flag to benchmark CI (#75)

dd321fd

fix traits

1de8334

Fix comments

80cabc2

clean a comment

5f3c1d7

fix: add explicit +nightly flag for cargo docs

7b917b2

Fix issues

79962ae

nit

66dc38f

chore: fix clippy false-positive and redundant types

2322544

chore: swap ARITY/COM argument order, expand on clippy note

598e34a

feat: upgrade Poseidon constants and LFSR APIs

9107d1f

chore: fix import issues

f9eeaaa

BoyuanFeng force-pushed the poseidon_optimization branch from 6061df0 to f9eeaaa Compare June 2, 2022 20:09

Boyuan Feng added 2 commits June 2, 2022 16:17

Merge branch 'main' into poseidon_optimization

46dd640

Add a hard-coded test to poseidon hash

afd6931

bhgomes requested review from tsunrise and bhgomes June 2, 2022 22:37

bhgomes approved these changes Jun 2, 2022

View reviewed changes

tsunrise approved these changes Jun 2, 2022

View reviewed changes

BoyuanFeng merged commit 98d0091 into main Jun 2, 2022

BoyuanFeng deleted the poseidon_optimization branch June 2, 2022 22:41

tsunrise mentioned this pull request Jun 27, 2022

Poseidon hash Manta-Network/Plonk-Prototype#3

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Parameter Generation for Poseidon Hash #57

Feature: Parameter Generation for Poseidon Hash #57

BoyuanFeng commented May 2, 2022 •

edited by tsunrise

Loading

tsunrise left a comment

bhgomes left a comment

tsunrise left a comment

tsunrise left a comment

bhgomes commented May 23, 2022

tsunrise left a comment •

edited

Loading

tsunrise left a comment

Feature: Parameter Generation for Poseidon Hash #57

Feature: Parameter Generation for Poseidon Hash #57

Conversation

BoyuanFeng commented May 2, 2022 • edited by tsunrise Loading

tsunrise left a comment

Choose a reason for hiding this comment

bhgomes left a comment

Choose a reason for hiding this comment

tsunrise left a comment

Choose a reason for hiding this comment

tsunrise left a comment

Choose a reason for hiding this comment

bhgomes commented May 23, 2022

tsunrise left a comment • edited Loading

Choose a reason for hiding this comment

tsunrise left a comment

Choose a reason for hiding this comment

BoyuanFeng commented May 2, 2022 •

edited by tsunrise

Loading

tsunrise left a comment •

edited

Loading