Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce the Sample API to just RngCore #127

Merged
merged 6 commits into from
Jun 24, 2022
Merged

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Jun 21, 2022

In order to make Sample compatible with non-cryptographic PRNGs (like the LFSR used in Poseidon) we need to remove the restriction that CryptoRng should be implemented for all RNGs supported in Sample::sample.


Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
CHANGELOG.md Outdated Show resolved Hide resolved
manta-crypto/src/eclair/ops.rs Outdated Show resolved Hide resolved
@bhgomes bhgomes marked this pull request as ready for review June 24, 2022 20:18
@bhgomes bhgomes added this to the v0.5.2 milestone Jun 24, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
@BoyuanFeng BoyuanFeng added the changelog:changed Changelog: add these changes to the `changed` section of the changelog label Jun 24, 2022
@bhgomes bhgomes merged commit 844204e into main Jun 24, 2022
@bhgomes bhgomes deleted the fix/reduce-sample-api branch June 24, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:changed Changelog: add these changes to the `changed` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants