Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more parameter loading utilities #128

Merged
merged 5 commits into from
Jun 23, 2022
Merged

feat: add more parameter loading utilities #128

merged 5 commits into from
Jun 23, 2022

Conversation

BoyuanFeng
Copy link
Contributor

@BoyuanFeng BoyuanFeng commented Jun 21, 2022 •
edited
Loading

Signed-off-by: Boyuan Feng bfeng9@wisc.edu

Description

Add more parameter loading utilities in manta-pay such that repos such as Manta an manta-signer do not need to touch manta-parameters.

This PR is the first step to solving #110.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

feat: add more parameter loading utilities
5c3e785 
Signed-off-by: Boyuan Feng <bfeng9@wisc.edu>
@BoyuanFeng BoyuanFeng mentioned this pull request Jun 21, 2022
Closed
3 tasks
@BoyuanFeng BoyuanFeng added this to the v0.5.3 milestone Jun 21, 2022
@BoyuanFeng BoyuanFeng added the changelog:added Changelog: add these changes to the `added` section of the changelog label Jun 21, 2022
@BoyuanFeng BoyuanFeng self-assigned this Jun 21, 2022
bhgomes
bhgomes suggested changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@bhgomes bhgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Just a few minor changes.

manta-pay/src/parameters.rs Outdated Show resolved Hide resolved
manta-pay/src/parameters.rs Outdated Show resolved Hide resolved
manta-pay/src/parameters.rs Outdated Show resolved Hide resolved
manta-pay/src/parameters.rs Outdated Show resolved Hide resolved
manta-pay/src/parameters.rs Outdated Show resolved Hide resolved
manta-pay/src/parameters.rs Outdated Show resolved Hide resolved
manta-pay/src/parameters.rs Outdated Show resolved Hide resolved
manta-pay/src/parameters.rs Outdated Show resolved Hide resolved
manta-pay/src/parameters.rs Outdated Show resolved Hide resolved
@BoyuanFeng BoyuanFeng linked an issue Jun 22, 2022 that may be closed by this pull request
Add more parameter loading utilities #110
Closed
3 tasks
@BoyuanFeng BoyuanFeng requested a review from tsunrise June 22, 2022 22:08
bhgomes
bhgomes suggested changes Jun 22, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@bhgomes bhgomes modified the milestones: v0.5.3, v0.5.2 Jun 23, 2022
@BoyuanFeng BoyuanFeng merged commit df9b2f7 into main Jun 23, 2022
@BoyuanFeng BoyuanFeng deleted the feat/more-parameter-loading-utilities branch June 23, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsunrise tsunrise tsunrise approved these changes

@bhgomes bhgomes bhgomes approved these changes

Assignees

@BoyuanFeng BoyuanFeng

Labels
changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
v0.5.2
Development

Successfully merging this pull request may close these issues.

Add more parameter loading utilities
3 participants
@BoyuanFeng @bhgomes @tsunrise