Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new encryption scheme abstractions #137

Merged
merged 14 commits into from
Jul 1, 2022
Merged

feat: add new encryption scheme abstractions #137

merged 14 commits into from
Jul 1, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Jun 28, 2022 •
edited
Loading

  • Updates encryption scheme APIs including the hybrid encryption protocols and converters
  • Adds duplex encryption

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@bhgomes bhgomes added changelog:changed Changelog: add these changes to the `changed` section of the changelog norelease labels Jun 28, 2022
@bhgomes bhgomes added changelog:added Changelog: add these changes to the `added` section of the changelog and removed changelog:changed Changelog: add these changes to the `changed` section of the changelog labels Jun 28, 2022
@bhgomes bhgomes requested review from BoyuanFeng and tsunrise and removed request for BoyuanFeng June 28, 2022 14:06
@bhgomes bhgomes marked this pull request as ready for review June 28, 2022 14:14
tsunrise
tsunrise suggested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@tsunrise tsunrise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit & minor comments

manta-crypto/src/encryption/mod.rs Outdated Show resolved Hide resolved
manta-crypto/src/encryption/mod.rs Outdated Show resolved Hide resolved
manta-crypto/src/permutation/duplex.rs Outdated Show resolved Hide resolved
manta-crypto/src/permutation/duplex.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/encryption/aes.rs Show resolved Hide resolved
manta-util/src/iter/mod.rs Show resolved Hide resolved
manta-util/src/lib.rs Show resolved Hide resolved
@bhgomes bhgomes requested a review from tsunrise July 1, 2022 14:21
@bhgomes bhgomes added this to the v0.5.3 milestone Jul 1, 2022
@bhgomes bhgomes merged commit 759c91f into main Jul 1, 2022
@bhgomes bhgomes deleted the feat/encryption branch July 1, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsunrise tsunrise tsunrise approved these changes

@BoyuanFeng BoyuanFeng BoyuanFeng approved these changes

Assignees
No one assigned
Labels
changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
v0.5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@bhgomes @tsunrise @BoyuanFeng