Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move HTTP utilities to manta-util #191

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Move HTTP utilities to manta-util #191

merged 2 commits into from
Aug 1, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Jul 31, 2022 •
edited
Loading

Signed-off-by: Brandon H. Gomes bhgomes@pm.me

  • Move tide HTTP server utilities from manta-signer to manta-util
  • Move reqwest HTTP client utilities from manta-pay to manta-util

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.
  • Ran cargo hakari generate to update the workspace-hack system

@bhgomes
feat: move HTTP utilities to manta-util
13ccef8 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
chore: update dependencies and add CHANGELOG entry
e3f6206 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes marked this pull request as ready for review July 31, 2022 03:12
@bhgomes bhgomes added changelog:changed Changelog: add these changes to the `changed` section of the changelog C-cleanup Category: Issues documenting cleanup or PRs that clean code up labels Jul 31, 2022
@bhgomes bhgomes added this to the v0.6.0 milestone Jul 31, 2022
@bhgomes bhgomes added A-development Area: Development Resources and Upgrades A-network Area: Issues and PRs related to Network Communication and Protocols A-design Area: Design of Libraries and APIs labels Jul 31, 2022
@bhgomes bhgomes merged commit 4cfc998 into main Aug 1, 2022
@bhgomes bhgomes deleted the feat/http-utils branch August 1, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoyuanFeng BoyuanFeng BoyuanFeng approved these changes

@GhostOfGauss GhostOfGauss GhostOfGauss approved these changes

@tsunrise tsunrise Awaiting requested review from tsunrise

@SupremoUGH SupremoUGH Awaiting requested review from SupremoUGH

Assignees
No one assigned
Labels
A-design Area: Design of Libraries and APIs A-development Area: Development Resources and Upgrades A-network Area: Issues and PRs related to Network Communication and Protocols C-cleanup Category: Issues documenting cleanup or PRs that clean code up changelog:changed Changelog: add these changes to the `changed` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhgomes @BoyuanFeng @GhostOfGauss