Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windowing algorithm for point multiplication #215

Merged
merged 23 commits into from
Sep 7, 2022
Merged

Windowing algorithm for point multiplication #215

merged 23 commits into from
Sep 7, 2022

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Aug 23, 2022 •
edited by bhgomes
Loading

New:
manta-crypto:

  • eclair::bool.rs: Added select_from_table function with default implementation to ConditionalSelect trait.
  • algebra.rs: Added add_assign, double_assign and repeated_double_assign methods with default implementations to Group trait.
  • algebra.rs: Added Window struct. The method scalar_mul implements windowed multiplication.
  • algebra.rs: Added abstract correctness test window_multiplication_correctness for scalar_mul.

manta-pay:

  • crypto::ecc::arkworks.rs: Implemented the PartialEq, ConditionalSelect and Zero traits from eclair for Group<C> and GroupVar.
  • crypto::ecc::arkworks.rs: Added windowed_mul_is_correct test which tests a concrete implementation of Window for the native rust compiler.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@SupremoUGH SupremoUGH self-assigned this Aug 24, 2022
@SupremoUGH SupremoUGH added changelog:added Changelog: add these changes to the `added` section of the changelog A-cryptography Area: Issues and PRs related to Cryptography labels Aug 24, 2022
@SupremoUGH SupremoUGH marked this pull request as ready for review August 24, 2022 17:47
@SupremoUGH SupremoUGH added the A-performance Area: Performance-related Issues and PRs label Aug 24, 2022
bhgomes
bhgomes suggested changes Aug 24, 2022
View reviewed changes
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-pay/src/crypto/ecc/arkworks.rs Outdated Show resolved Hide resolved
manta-crypto/src/eclair/bool.rs Outdated Show resolved Hide resolved
manta-crypto/src/algebra.rs Outdated Show resolved Hide resolved
manta-crypto/src/algebra.rs Outdated Show resolved Hide resolved
manta-crypto/src/algebra.rs Show resolved Hide resolved
manta-crypto/src/algebra.rs Outdated Show resolved Hide resolved
manta-crypto/src/algebra.rs Outdated Show resolved Hide resolved
manta-crypto/src/algebra.rs Outdated Show resolved Hide resolved
manta-crypto/src/algebra.rs Outdated Show resolved Hide resolved
bhgomes
bhgomes suggested changes Aug 25, 2022
View reviewed changes
manta-pay/Cargo.toml Outdated Show resolved Hide resolved
manta-crypto/src/eclair/bool.rs Show resolved Hide resolved
@SupremoUGH SupremoUGH closed this Aug 26, 2022
@SupremoUGH SupremoUGH reopened this Aug 26, 2022
SupremoUGH and others added 2 commits August 25, 2022 20:03
@SupremoUGH
Format
1dc166e 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@bhgomes
Merge branch 'main' into feat/implement_windowing_ecc
e5fa03c
@bhgomes bhgomes requested a review from tsunrise August 29, 2022 15:39
@bhgomes bhgomes added the P-high Priority: High label Aug 29, 2022
@bhgomes
Merge branch 'main' into feat/implement_windowing_ecc
1543c5b 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
tsunrise
tsunrise suggested changes Aug 31, 2022
View reviewed changes
manta-crypto/src/algebra.rs Outdated Show resolved Hide resolved
manta-crypto/src/algebra.rs Show resolved Hide resolved
@SupremoUGH
wip: commit save point
b7783ea 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
tsunrise
tsunrise previously approved these changes Aug 31, 2022
View reviewed changes
@SupremoUGH
Merge branch 'main' into feat/implement_windowing_ecc
300ddc1
@SupremoUGH
Lint error fixed.
e8ea37f 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
lint issues
abeb5f6 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
lint
beb6f33 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
bhgomes
bhgomes suggested changes Sep 7, 2022
View reviewed changes
manta-crypto/src/algebra.rs Outdated Show resolved Hide resolved
@bhgomes
Update manta-crypto/src/algebra.rs
d5576e0 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
bhgomes
bhgomes previously approved these changes Sep 7, 2022
View reviewed changes
@bhgomes
chore: fix formatting
4ebbef8 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
bhgomes
bhgomes previously approved these changes Sep 7, 2022
View reviewed changes
BoyuanFeng
BoyuanFeng suggested changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@BoyuanFeng BoyuanFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes

manta-crypto/src/algebra.rs Outdated Show resolved Hide resolved
manta-crypto/src/algebra.rs Show resolved Hide resolved
manta-crypto/src/eclair/bool.rs Outdated Show resolved Hide resolved
@SupremoUGH
Comments addressed
c384943 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@bhgomes bhgomes merged commit c5392dd into main Sep 7, 2022
@bhgomes bhgomes deleted the feat/implement_windowing_ecc branch September 7, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhgomes bhgomes bhgomes approved these changes

@BoyuanFeng BoyuanFeng BoyuanFeng approved these changes

@tsunrise tsunrise Awaiting requested review from tsunrise

@GhostOfGauss GhostOfGauss Awaiting requested review from GhostOfGauss

Assignees

@SupremoUGH SupremoUGH

Labels
A-cryptography Area: Issues and PRs related to Cryptography A-performance Area: Performance-related Issues and PRs changelog:added Changelog: add these changes to the `added` section of the changelog P-high Priority: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SupremoUGH @bhgomes @tsunrise @BoyuanFeng