Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: fuzzing test #237

Merged
merged 17 commits into from
Sep 8, 2022
Merged

Feat: fuzzing test #237

merged 17 commits into from
Sep 8, 2022

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Aug 31, 2022 •
edited by bhgomes
Loading

NEW:

  • rand.rs: Added fuzz module with Fuzz trait, which flips a bit at random of a given element.
  • constraint.rs: Added fuzz_public_input test for ProofSystem implementations.
  • test::transfer.rs: Added fuzzing tests for the Mint, PrivateTransfer and Reclaim protocols.

Closes #158

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@SupremoUGH
Fuzzing trait defined
fe332a5
@SupremoUGH
Merge branch 'main' into feat/fuzzing_test
68c60cd
@SupremoUGH
Removed Fuzzing Trait
4a8657d
@SupremoUGH
Fuzzed and randomized public input tests
c574ac3 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
fuzz_public_input for ProofSystem
4355a5c 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
randomizing now integrated in fuzzing
523863b 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
Merge branch 'main' into feat/fuzzing_test
67fab9c
@SupremoUGH
Fuzz Trait integrated
52fba13 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
Unnecessary functions removed
ed2d6e8 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH SupremoUGH added the changelog:added Changelog: add these changes to the `added` section of the changelog label Sep 2, 2022
@SupremoUGH SupremoUGH self-assigned this Sep 2, 2022
@SupremoUGH SupremoUGH added A-cryptography Area: Issues and PRs related to Cryptography A-testing Area: Testing-related Issues and PRs P-medium Priority: Medium labels Sep 2, 2022
@SupremoUGH SupremoUGH marked this pull request as ready for review September 2, 2022 19:22
bhgomes
bhgomes suggested changes Sep 5, 2022
View reviewed changes
manta-crypto/src/rand.rs Outdated Show resolved Hide resolved
manta-crypto/src/rand.rs Outdated Show resolved Hide resolved
manta-crypto/src/rand.rs Outdated Show resolved Hide resolved
manta-crypto/src/constraint.rs Outdated Show resolved Hide resolved
manta-pay/src/test/transfer.rs Show resolved Hide resolved
manta-pay/src/test/transfer.rs Outdated Show resolved Hide resolved
@SupremoUGH
Comments addressed.
30f6df0 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
bhgomes
bhgomes suggested changes Sep 6, 2022
View reviewed changes
manta-pay/src/test/transfer.rs Outdated Show resolved Hide resolved
@SupremoUGH
Lint error.
6c2dece 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
Comments addressed & lint issues
c439de0 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
lint issues
4148a67 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
lint
cae3d7c 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
bhgomes
bhgomes suggested changes Sep 7, 2022
View reviewed changes
manta-pay/src/test/transfer.rs Outdated Show resolved Hide resolved
manta-pay/src/test/transfer.rs Outdated Show resolved Hide resolved
manta-pay/src/test/transfer.rs Outdated Show resolved Hide resolved
manta-pay/src/test/transfer.rs Outdated Show resolved Hide resolved
manta-pay/src/test/transfer.rs Outdated Show resolved Hide resolved
@SupremoUGH
comments addressed
caadc06 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
bhgomes
bhgomes previously approved these changes Sep 7, 2022
View reviewed changes
@bhgomes
Merge branch 'main' into feat/fuzzing_test
d9ce336 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
bhgomes
bhgomes previously approved these changes Sep 7, 2022
View reviewed changes
BoyuanFeng
BoyuanFeng suggested changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@BoyuanFeng BoyuanFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues

manta-crypto/src/constraint.rs Show resolved Hide resolved
manta-crypto/src/constraint.rs Outdated Show resolved Hide resolved
@SupremoUGH
Comments addressed
f44dba0 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@bhgomes bhgomes merged commit 00e3c80 into main Sep 8, 2022
@bhgomes bhgomes deleted the feat/fuzzing_test branch September 8, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhgomes bhgomes bhgomes approved these changes

@BoyuanFeng BoyuanFeng BoyuanFeng approved these changes

@tsunrise tsunrise Awaiting requested review from tsunrise

@GhostOfGauss GhostOfGauss Awaiting requested review from GhostOfGauss

Assignees

@SupremoUGH SupremoUGH

Labels
A-cryptography Area: Issues and PRs related to Cryptography A-testing Area: Testing-related Issues and PRs changelog:added Changelog: add these changes to the `added` section of the changelog P-medium Priority: Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Public Input Fuzzing Test
3 participants
@SupremoUGH @bhgomes @BoyuanFeng