Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move arkworks curves to manta-crypto #247

Merged
merged 6 commits into from
Sep 9, 2022
Merged

Move arkworks curves to manta-crypto #247

merged 6 commits into from
Sep 9, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Sep 8, 2022 •
edited
Loading

Signed-off-by: Brandon H. Gomes bhgomes@pm.me

The following curves and related tests were moved to manta-crypto:

  • ark-bls12-381
  • ark-bn254
  • ark-ed-on-bls12-381
  • ark-ed-on-bn254

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@bhgomes
feat: move arkworks curves to manta-crypto
172abcc 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes self-assigned this Sep 8, 2022
@bhgomes bhgomes added the changelog:changed Changelog: add these changes to the `changed` section of the changelog label Sep 8, 2022
@bhgomes bhgomes added this to the v0.5.5 milestone Sep 8, 2022
@bhgomes
chore: update CHANGELOG and dependencies
ad473eb 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
wip: commit save point
2a4190e 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes marked this pull request as ready for review September 8, 2022 22:09
@bhgomes
chore: update dependencies
f76dcb5 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
chore: update rand-chacha dependency
50b7d56 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
SupremoUGH
SupremoUGH previously approved these changes Sep 8, 2022
View reviewed changes
@bhgomes bhgomes added A-openzl Area: Development Related to OpenZL and ECLAIR A-development Area: Development Resources and Upgrades labels Sep 8, 2022
@GhostOfGauss GhostOfGauss self-requested a review September 8, 2022 23:08
GhostOfGauss
GhostOfGauss previously approved these changes Sep 8, 2022
View reviewed changes
@bhgomes
chore: fix test dependency
0735973 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes dismissed stale reviews from GhostOfGauss and SupremoUGH via 0735973 September 8, 2022 23:17
@bhgomes bhgomes merged commit f511813 into main Sep 9, 2022
@bhgomes bhgomes deleted the feat/add-arkworks-curves branch September 9, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupremoUGH SupremoUGH SupremoUGH approved these changes

@GhostOfGauss GhostOfGauss GhostOfGauss approved these changes

@BoyuanFeng BoyuanFeng Awaiting requested review from BoyuanFeng

Assignees

@bhgomes bhgomes

Labels
A-development Area: Development Resources and Upgrades A-openzl Area: Development Related to OpenZL and ECLAIR changelog:changed Changelog: add these changes to the `changed` section of the changelog
Projects
None yet
Milestone
v0.5.5
Development

Successfully merging this pull request may close these issues.
3 participants
@bhgomes @SupremoUGH @GhostOfGauss