Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move R1CS compiler to manta-crypto #284

Merged
merged 5 commits into from
Nov 22, 2022
Merged

Move R1CS compiler to manta-crypto #284

merged 5 commits into from
Nov 22, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Nov 15, 2022 •
edited
Loading

Signed-off-by: Brandon H. Gomes bhgomes@pm.me

  • Moved R1CS compiler to manta-crypto
  • Removed some SCALE encoding support (was not being used anyway)

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@bhgomes
fix: move R1CS compiler to manta-crypto
a3faf49 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
chore: fix dependencies and CHANGELOG
a102ebc 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes marked this pull request as ready for review November 15, 2022 21:53
@bhgomes
chore: fix dependency issues
bb6dcee 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes added changelog:changed Changelog: add these changes to the `changed` section of the changelog P-high Priority: High A-cryptography Area: Issues and PRs related to Cryptography labels Nov 15, 2022
GhostOfGauss
GhostOfGauss previously approved these changes Nov 17, 2022
View reviewed changes
manta-crypto/src/arkworks/constraint/mod.rs Show resolved Hide resolved
SupremoUGH
SupremoUGH suggested changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@SupremoUGH SupremoUGH left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before approving this, what do you think is the optimal order to merge the three PRs so it minimises merge conflicts?
Also, I guess this closes #248.

manta-crypto/src/arkworks/constraint/fp.rs Show resolved Hide resolved
manta-crypto/src/arkworks/constraint/fp.rs Show resolved Hide resolved
manta-crypto/src/arkworks/constraint/fp.rs Show resolved Hide resolved
manta-crypto/src/arkworks/constraint/fp.rs Show resolved Hide resolved
manta-crypto/src/arkworks/constraint/fp.rs Show resolved Hide resolved
manta-crypto/src/arkworks/serialize.rs Show resolved Hide resolved
manta-crypto/src/arkworks/serialize.rs Show resolved Hide resolved
manta-crypto/src/arkworks/serialize.rs Show resolved Hide resolved
manta-crypto/src/arkworks/serialize.rs Show resolved Hide resolved
manta-crypto/src/arkworks/serialize.rs Show resolved Hide resolved
@bhgomes
Merge branch 'main' into feat/move-r1cs-to-manta-crypto
a9f45c1 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
fix: resolve review comments
f269eb0 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes linked an issue Nov 18, 2022 that may be closed by this pull request
Move the R1CS and relevant constructions into manta-crypto #226
Closed
@bhgomes bhgomes mentioned this pull request Nov 18, 2022
Closed
4 tasks
SupremoUGH
SupremoUGH approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@SupremoUGH SupremoUGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed, approve.

@bhgomes bhgomes merged commit 7302863 into main Nov 22, 2022
@bhgomes bhgomes deleted the feat/move-r1cs-to-manta-crypto branch November 22, 2022 04:26
@bhgomes bhgomes mentioned this pull request Nov 22, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupremoUGH SupremoUGH SupremoUGH approved these changes

@GhostOfGauss GhostOfGauss GhostOfGauss approved these changes

Assignees
No one assigned
Labels
A-cryptography Area: Issues and PRs related to Cryptography changelog:changed Changelog: add these changes to the `changed` section of the changelog P-high Priority: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move the R1CS and relevant constructions into manta-crypto
3 participants
@bhgomes @SupremoUGH @GhostOfGauss