Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset display fix #296

Merged
merged 10 commits into from
Dec 22, 2022
Merged

Asset display fix #296

merged 10 commits into from
Dec 22, 2022

Conversation

AlexParshh
Copy link
Contributor

@AlexParshh AlexParshh commented Dec 22, 2022

Fixes an edge case for the asset metadata display function that did not correctly display zeros after the decimal point but before other decimal values. For example, the value 0.01, and 0.1 were both being displayed as 0.1.


Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@AlexParshh AlexParshh added the changelog:fixed Changelog: add these changes to the `fixed` section of the changelog label Dec 22, 2022
Kevingislason
Kevingislason previously approved these changes Dec 22, 2022
Apokalip
Apokalip previously approved these changes Dec 22, 2022
@Apokalip Apokalip self-requested a review December 22, 2022 09:14
Signed-off-by: Apokalip <simeon@manta.network>
@Apokalip Apokalip dismissed stale reviews from Kevingislason and themself via 2f12db9 December 22, 2022 09:19
@Apokalip Apokalip added C-bug Category: Issues documenting a bug A-design Area: Design of Libraries and APIs T-fullstack Team: Relevant for the Fullstack Team labels Dec 22, 2022
Signed-off-by: Apokalip <simeon@manta.network>
Signed-off-by: Apokalip <simeon@manta.network>
@Kevingislason Kevingislason merged commit c3a9c74 into main Dec 22, 2022
@Kevingislason Kevingislason deleted the asset_display_fix branch December 22, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-design Area: Design of Libraries and APIs C-bug Category: Issues documenting a bug changelog:fixed Changelog: add these changes to the `fixed` section of the changelog T-fullstack Team: Relevant for the Fullstack Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants