Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Signer to WASM #314

Merged
merged 47 commits into from
Feb 14, 2023
Merged

Export Signer to WASM #314

merged 47 commits into from
Feb 14, 2023

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Jan 31, 2023

Goes together with Manta-Network/sdk#78.

Changes:

  • Refactored most SignerState methods as free functions.
  • Included sign_with_transaction_data compound method with a test.
  • Removed std from wallet feature because of compatibility issues with sdk. Changed the AssetMap from HashMap to BTreeMap as a consequence.
  • Several trait implementations (mostly (de)Serialize and Hash) for compatibility with sdk.
  • Several type definitions.
  • Removed network feature.

Misc:

  • Removed unused utxo_utilities module.
  • Improved TransactionData verification method.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@SupremoUGH SupremoUGH self-assigned this Jan 31, 2023
@SupremoUGH SupremoUGH added A-design Area: Design of Libraries and APIs changelog:added Changelog: add these changes to the `added` section of the changelog labels Jan 31, 2023
@SupremoUGH SupremoUGH marked this pull request as ready for review January 31, 2023 20:16
@SupremoUGH SupremoUGH requested a review from zqhxuyuan February 2, 2023 11:40
@zqhxuyuan
Copy link

zqhxuyuan commented Feb 2, 2023

Mabye rename package name methods to impl or util, or functions?
PS: I prefer functions instead of methods. like substrate way: https://github.com/paritytech/substrate/blob/master/frame/assets/src/functions.rs

@SupremoUGH SupremoUGH marked this pull request as draft February 2, 2023 19:54
@SupremoUGH SupremoUGH changed the title Stateless Signer Export Signer to WASM Feb 7, 2023
@SupremoUGH SupremoUGH marked this pull request as ready for review February 7, 2023 18:50
@SupremoUGH SupremoUGH requested a review from Apokalip February 7, 2023 19:01
manta-pay/Cargo.toml Outdated Show resolved Hide resolved
manta-pay/src/signer/client/network.rs Outdated Show resolved Hide resolved
manta-pay/src/key.rs Show resolved Hide resolved
manta-crypto/src/arkworks/groth16.rs Show resolved Hide resolved
manta-crypto/src/arkworks/groth16.rs Show resolved Hide resolved
manta-accounting/src/wallet/signer/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Francisco Hernández Iglesias <38819712+SupremoUGH@users.noreply.github.com>
@SupremoUGH SupremoUGH requested a review from bhgomes February 9, 2023 12:47
bhgomes
bhgomes previously approved these changes Feb 10, 2023
@SupremoUGH SupremoUGH requested a review from bhgomes February 13, 2023 14:23
@SupremoUGH SupremoUGH merged commit 9f020c9 into main Feb 14, 2023
@SupremoUGH SupremoUGH deleted the feat/good_stateless_signer branch February 14, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-design Area: Design of Libraries and APIs changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants