-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export Signer to WASM #314
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupremoUGH
added
A-design
Area: Design of Libraries and APIs
changelog:added
Changelog: add these changes to the `added` section of the changelog
labels
Jan 31, 2023
zqhxuyuan
reviewed
Feb 2, 2023
Mabye rename package name |
3 tasks
4 tasks
bhgomes
suggested changes
Feb 8, 2023
Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Francisco Hernández Iglesias <38819712+SupremoUGH@users.noreply.github.com>
…-Network/manta-rs into feat/good_stateless_signer
bhgomes
previously approved these changes
Feb 10, 2023
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
bhgomes
approved these changes
Feb 13, 2023
Apokalip
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-design
Area: Design of Libraries and APIs
changelog:added
Changelog: add these changes to the `added` section of the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes together with Manta-Network/sdk#78.
Changes:
SignerState
methods as free functions.sign_with_transaction_data
compound method with a test.std
fromwallet
feature because of compatibility issues withsdk
. Changed theAssetMap
fromHashMap
toBTreeMap
as a consequence.(de)Serialize
andHash
) for compatibility withsdk
.network
feature.Misc:
utxo_utilities
module.TransactionData
verification method.Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.md
and added the appropriatechangelog
label to the PR.Files changed
in the GitHub PR explorer.CONTRIBUTING.md
.