-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Key Dependent Signer Function APIs #319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupremoUGH
added
the
changelog:added
Changelog: add these changes to the `added` section of the changelog
label
Feb 16, 2023
3 tasks
bhgomes
suggested changes
Feb 17, 2023
4 tasks
bhgomes
approved these changes
Feb 21, 2023
DanielZhangReal
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes together with Manta-Network/sdk#85
Changes for
Signer
andSignerState
inmanta-accounting::wallet::signer
:SignerState
, instead of anAccountTable
to be initialized, now it hasOption<AccountTable>
andOption<AuthorizationContext>
.sign
requiresAccountTable
to be there. New field inSignError
if it'sNone
.sync
requiresAuthorizationContext
to be there. New field inSyncError
if it'sNone
.AccountTable
, and loading/droppingAccountTable
andAuthorizationContext
.More changes with design decisions:
address
requiresAccountTable
. We could require the weakerAuthorizationContext
for this, or, have anAddress
field inSignerState
because it is the lowest level of security.address
now returnsOption<Address>
because of this.transaction_data
requiresAccountTable
. We could require the weakerAuthorizationContext
for this or, have aDecryptionKey
field inSignerState
because that's all it's needed. However, it makes sense to require theAccountTable
because it's commonly used in the compound methodsign_with_transaction_data
, which does requireAccountTable
.transaction_data
andidentity_proof
still returnOption
. Perhaps it makes sense that they return more verboseResult
s now?manta-pay::signer::functions.rs
changes:new_signer
initializes the signer with just parameters and optionally the state.Mnemonic
.Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.md
and added the appropriatechangelog
label to the PR.Files changed
in the GitHub PR explorer.CONTRIBUTING.md
.