Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch insert #330

Merged
merged 59 commits into from
Apr 6, 2023
Merged

Batch insert #330

merged 59 commits into from
Apr 6, 2023

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Mar 24, 2023 •
edited
Loading

Description:

Adds batch insertion methods to the Merkle Tree implementations, in particular to Full, Partial, Fork and Forest. Implements batch insertion as the default for the sync protocol.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

SupremoUGH and others added 30 commits March 14, 2023 17:49
@SupremoUGH SupremoUGH self-assigned this Mar 28, 2023
@SupremoUGH SupremoUGH added the changelog:added Changelog: add these changes to the `added` section of the changelog label Mar 29, 2023
@SupremoUGH SupremoUGH marked this pull request as ready for review March 29, 2023 18:31
@SupremoUGH SupremoUGH added the A-cryptography Area: Issues and PRs related to Cryptography label Mar 29, 2023
@SupremoUGH SupremoUGH requested review from bhgomes and Apokalip March 29, 2023 18:32
Apokalip
Apokalip previously approved these changes Mar 29, 2023
View reviewed changes
manta-crypto/src/merkle_tree/full.rs Show resolved Hide resolved
bhgomes
bhgomes suggested changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@bhgomes bhgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial Review: I still have 4 more files to read.

manta-crypto/src/accumulator.rs Outdated Show resolved Hide resolved
manta-crypto/src/accumulator.rs Outdated Show resolved Hide resolved
manta-crypto/src/merkle_tree/test/batch_insertion.rs Outdated Show resolved Hide resolved
manta-crypto/src/merkle_tree/test/batch_insertion.rs Show resolved Hide resolved
manta-crypto/src/merkle_tree/test/batch_insertion.rs Outdated Show resolved Hide resolved
manta-crypto/src/merkle_tree/forest.rs Outdated Show resolved Hide resolved
manta-crypto/src/merkle_tree/node.rs Outdated Show resolved Hide resolved
manta-crypto/src/merkle_tree/node.rs Show resolved Hide resolved
manta-crypto/src/merkle_tree/node.rs Outdated Show resolved Hide resolved
manta-crypto/src/merkle_tree/node.rs Outdated Show resolved Hide resolved
@SupremoUGH SupremoUGH requested a review from bhgomes April 3, 2023 19:16
@SupremoUGH SupremoUGH requested a review from Apokalip April 4, 2023 15:49
@SupremoUGH SupremoUGH merged commit 5167e8c into main Apr 6, 2023
@SupremoUGH SupremoUGH deleted the batch_insert branch April 6, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apokalip Apokalip Apokalip approved these changes

@bhgomes bhgomes bhgomes approved these changes

Assignees

@SupremoUGH SupremoUGH

Labels
A-cryptography Area: Issues and PRs related to Cryptography changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SupremoUGH @bhgomes @Apokalip