Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signer bug fix #347

Merged
merged 28 commits into from
May 19, 2023
Merged

Signer bug fix #347

merged 28 commits into from
May 19, 2023

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented May 18, 2023 •
edited
Loading

Fixes the infamous Wallet AssetSpent bug. Goes together with Manta-Network/sdk#129

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

SupremoUGH and others added 27 commits May 8, 2023 18:00
@SupremoUGH SupremoUGH self-assigned this May 18, 2023
@SupremoUGH SupremoUGH added the changelog:fixed Changelog: add these changes to the `fixed` section of the changelog label May 18, 2023
@SupremoUGH SupremoUGH mentioned this pull request May 18, 2023
Merged
3 tasks
@SupremoUGH SupremoUGH added P-high Priority: High C-bug Category: Issues documenting a bug labels May 18, 2023
@SupremoUGH SupremoUGH marked this pull request as ready for review May 18, 2023 17:56
@SupremoUGH SupremoUGH marked this pull request as draft May 18, 2023 17:56
@ghzlatarev ghzlatarev requested a review from Apokalip May 19, 2023 10:52
@SupremoUGH SupremoUGH requested a review from ghzlatarev May 19, 2023 10:53
@SupremoUGH SupremoUGH marked this pull request as ready for review May 19, 2023 12:38
@SupremoUGH SupremoUGH mentioned this pull request May 19, 2023
Closed
@SupremoUGH SupremoUGH merged commit 82606a8 into main May 19, 2023
@SupremoUGH SupremoUGH deleted the signer_bug_fix branch May 19, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghzlatarev ghzlatarev ghzlatarev approved these changes

@Apokalip Apokalip Apokalip approved these changes

@zqhxuyuan zqhxuyuan Awaiting requested review from zqhxuyuan

Assignees

@SupremoUGH SupremoUGH

Labels
C-bug Category: Issues documenting a bug changelog:fixed Changelog: add these changes to the `fixed` section of the changelog P-high Priority: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SupremoUGH @Apokalip @ghzlatarev